Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-byte drop in VNG file size #4821

Closed
philrz opened this issue Oct 24, 2023 · 1 comment
Closed

2-byte drop in VNG file size #4821

philrz opened this issue Oct 24, 2023 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@philrz
Copy link
Contributor

philrz commented Oct 24, 2023

Repro is with Zed commit 88f40ed and the test data file sample.tsv from the Zui repo.

At commit c29dd97 right before the changes in #4812, output the sorted file as VNG.

$ zq -version
Version: v1.10.0-14-gc29dd976

$ zq -f vng 'sort ts' sample.tsv > /tmp/c29dd97.vng

Repeat the same at commit 88f40ed, which is associated with the changes in #4812.

$ zq -version
Version: v1.10.0-15-g88f40edd

$ zq -f vng 'sort ts' sample.tsv > /tmp/88f40ed.vng

We find the newer VNG output is 2 bytes smaller than before.

$ ls -l /tmp/*.vng
-rw-r--r--  1 phil  wheel  7740 Oct 24 10:35 /tmp/88f40ed.vng
-rw-r--r--  1 phil  wheel  7742 Oct 24 10:34 /tmp/c29dd97.vng

Since the changes in #4812 impacted the amount of memory used to store values, I thought this might have been an expected result, but @nwt confirmed it's unexpected. Hence this issue.

@philrz philrz added the bug Something isn't working label Oct 24, 2023
@philrz philrz changed the title Unexpected 2-byte drop in VNG file size 2-byte drop in VNG file size Oct 24, 2023
@philrz
Copy link
Contributor Author

philrz commented Oct 24, 2023

@nwt took a closer look and confirmed this is expected after all. Will plan to update the related Zui test to expect this change. Closing.

@philrz philrz closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
@philrz philrz added wontfix This will not be worked on and removed bug Something isn't working labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants