Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Load successful" pop-up to reflect partial loads #2660

Closed
philrz opened this issue Feb 7, 2023 · 1 comment · Fixed by #2834
Closed

Change "Load successful" pop-up to reflect partial loads #2660

philrz opened this issue Feb 7, 2023 · 1 comment · Fixed by #2834
Assignees

Comments

@philrz
Copy link
Contributor

philrz commented Feb 7, 2023

Repro is with Zui commit a372438.

The attached video is from the verification of #2554. Right now when a load partially succeeds, the user is simultaneously shown messages that say "Ingest failed with warnings" and "Load successful". Since "load" and "ingest" are roughly synonymous, this seems confusing. It would be helpful if the "Load successful" could be adjusted in this case to reflect that the load only partially succeeded and that the user is seeing a subset of the data they tried to load.

Verify.mp4
@philrz
Copy link
Contributor Author

philrz commented Feb 21, 2024

As shown in the attached video, this issue was effectively fixed by the changes in #2834 since "partial loads" are no longer possible in Zui. When a file is staged in Preview & Load, any attempt to load as a format that zq can't parse will prevent the Load button from activating. And if Preview is bypassed by holding down Shift when dragging files into the app, the whole load operation will fail and an empty pool will remain.

Verify.mp4

Zed issue #4546 tracks the wider topic of when support might be added for "partial loads", and surely we'll want good error reporting to be a part of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants