Skip to content

Commit

Permalink
Fix using default Docker struct
Browse files Browse the repository at this point in the history
  • Loading branch information
mikusaq committed Jan 3, 2025
1 parent 787d22f commit 55be4f4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions modules/bringauto_build/Build.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,20 @@ type Build struct {
sysroot *bringauto_sysroot.Sysroot
}

type buildInitArgs struct {
DockerImageName string
}

// FillDefault
// It fills up defaults for all members in the Build structure.
func (build *Build) FillDefault(*bringauto_prerequisites.Args) error {
func (build *Build) FillDefault(args *bringauto_prerequisites.Args) error {
var argsStruct buildInitArgs
bringauto_prerequisites.GetArgs(args, &argsStruct)
if build.Git == nil {
build.Git = bringauto_prerequisites.CreateAndInitialize[bringauto_git.Git]()
}
if build.Docker == nil {
build.Docker = bringauto_prerequisites.CreateAndInitialize[bringauto_docker.Docker]()
build.Docker = bringauto_prerequisites.CreateAndInitialize[bringauto_docker.Docker](argsStruct.DockerImageName)
}
if build.SSHCredentials == nil {
build.SSHCredentials = bringauto_prerequisites.CreateAndInitialize[bringauto_ssh.SSHCredentials]()
Expand Down
2 changes: 1 addition & 1 deletion modules/bringauto_config/Config.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (config *Config) GetBuildStructure(imageName string, platformString *bringa
continue
}
build := config.fillBuildStructure(imageName, platformString)
defaultBuild := bringauto_prerequisites.CreateAndInitialize[bringauto_build.Build]()
defaultBuild := bringauto_prerequisites.CreateAndInitialize[bringauto_build.Build](imageName)
err := copier.CopyWithOption(defaultBuild, build, copier.Option{DeepCopy: true, IgnoreEmpty: true})
if err != nil {
panic(fmt.Errorf("cannot merge default and real build config"))
Expand Down

0 comments on commit 55be4f4

Please sign in to comment.