-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different output formats #2
Comments
Hi @spekulatius - are you able to elaborate a little on your vision for this issue? The module currently doesn't output anything, merely caches the info for future use. Did you intend to:
If the latter, do you think it's necessary? It would basically be re-creating the output of the SensioLabs module e.g. JSON example found at https://security.sensiolabs.org/api (base of page)
|
Hey @NightJar Its been a while. I'm not sure I can recollect the idea behind this. You are right that it would pretty much replicate the Sensiolabs API as it looks. Should we just close it? Cheers, |
I think adding an access point for external consumption would be dangerous, so I would imagine this was probably in the form of an export, such as the one found on most ModelAdmin pages. We have converted silverstripe-maintenance into a report, which supports export as CSV. The idea behind the extensions in #34 is to link the two and provide extra report fields*, which would provide this in part - with the exception of various formats. The issue with hooking silverstripe-maintenance report is that exporting currently requires it - where this module does not require silverstripe-maintenance, nor provides any interface at all for that matter. Would you prefer us to keep a separtae (admin) interface at the ready for this module? It could include multiple export formats, and probably even only optionally enabled via config. |
Hello @NightJar originally this module itself didn't have any way of exposing the information - for good reasons. The maintenance module did this job. I'm happy to keep it this way. FYI @robbieaverill Cheers, |
Neat, thanks for the timely responses @spekulatius - I'll just close this :) |
No worries @NightJar |
To allow automatic validation of the output it needs to be easily machine readable (e.g. as a JSON or XML). Currently this isn't an option.
The text was updated successfully, but these errors were encountered: