Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for the DataExtensions #35

Closed
1 task done
NightJar opened this issue May 29, 2018 · 1 comment
Closed
1 task done

Write tests for the DataExtensions #35

NightJar opened this issue May 29, 2018 · 1 comment

Comments

@NightJar
Copy link
Contributor

NightJar commented May 29, 2018

Integration tests more than unit, however the module currently has support for the silverstripe-maintenance module iff it is installed, but does not test this.

Usage of setUpOnce/setUp to test if the bringyourownideas/silverstripe-maintenance module exists, and using $this->markTestSkipped('Maintenance module not present') would see us able to use some fixtures and test various points of the extensions, such as whether or not the appropriate asset files are included (css,js), outputs are modified, etc.

@robbieaverill
Copy link
Contributor

There's a bunch of situations where we've got extra modules installed in some CI build situations (like adding in subsites or queuedjobs) - would be good to add it for some but not all matrix entries, and ensure that if you're skipping tests that don't have a module present that you'd run code coverage on the run that has the least number of tests skipped =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants