Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Replace sensiolabs/security-checker with signify-nz/composer-security-checker #59

Closed
wants to merge 1 commit into from
Closed

FIX: Replace sensiolabs/security-checker with signify-nz/composer-security-checker #59

wants to merge 1 commit into from

Conversation

GuySartorelli
Copy link
Collaborator

Fixes #57

@GuySartorelli GuySartorelli mentioned this pull request Dec 22, 2021
Closed
@GuySartorelli
Copy link
Collaborator Author

Scrutinizer failed because the composer1 cache hasn't got the new package yet (though why scrutinizer is using composer1 I couldn't tell you). Should be visible to composer1 in a day or so.

@GuySartorelli GuySartorelli mentioned this pull request Dec 22, 2021
Closed
@GuySartorelli GuySartorelli force-pushed the fix/replace-sensiolabs-security-checker branch from 138f800 to 66ca962 Compare December 22, 2021 20:36
@GuySartorelli
FIX: Replace sensiolabs/security-checker with signify-nz/composer-sec…
2278fd6 
…urity-checker

FIX Don't instantiate security checker for /dev/tasks request.

The new security checker fetches data on instantiation. There's no reason to trigger that every time a developer goes to /dev/tasks.
@GuySartorelli GuySartorelli force-pushed the fix/replace-sensiolabs-security-checker branch from 66ca962 to 2278fd6 Compare January 16, 2022 23:09
@GuySartorelli
Copy link
Collaborator Author

Scrutinizer failed this time because it's trying to use PHP 5.6... someone with access and appropriate know-how will need to update the configuration for this package's scrutinizer run.

maxime-rainville
maxime-rainville requested changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but I'm thinking it might make more sense to use the Packagist security advisory API instead. I'm thinking that's probably going to more reliable in the long term.

@GuySartorelli
Copy link
Collaborator Author

Closing this as it's not an accepted approach.
Some cool Guy has created a PR in composer/composer which will add a PHP API for consuming the packagist security advisory API, so when that's merged I'll create a new PR that leverages it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module no longer works, sensiolabs/security-checker is abandoned
2 participants
@GuySartorelli @maxime-rainville