Disable function::target if rtti is disabled

Author: dancazarin

examples/showcase/src/Dialogs.cpp

@@ -17,6 +17,8 @@ static RC<Widget> osDialogButton(std::string text, Listener<> fn) {
 
 class SmallComponent : public Component {
 public:
+    ~SmallComponent() override = default;
+
     RC<Widget> build() final {
         return rcnew Widget{
             stylesheet = Graphene::stylesheet(),

include/brisk/core/Binding.hpp

@@ -1750,6 +1750,8 @@ class BindingObject : public Object, public std::enable_shared_from_this<Binding
     using Base = std::enable_shared_from_this<BindingObject<Derived, scheduler>>;
 
 public:
+    ~BindingObject() override {}
+
     using Ptr = std::shared_ptr<Derived>;
 
     [[nodiscard]] std::shared_ptr<Derived> shared_from_this() {

include/brisk/core/internal/Function.hpp

@@ -33,9 +33,11 @@ template <typename R, typename... Args>
 struct fn_base {
     virtual ~fn_base() {}
 
-    virtual R operator()(Args... args)                         = 0;
+    virtual R operator()(Args... args) = 0;
+#ifdef BRISK_RTTI
     virtual const std::type_info& target_type() const noexcept = 0;
     virtual void* target() noexcept                            = 0;
+#endif
 };
 
 template <typename Fn, typename R, typename... Args>
@@ -49,13 +51,15 @@ struct fn_impl : public fn_base<R, Args...> {
         return fn(std::forward<Args>(args)...);
     }
 
+#ifdef BRISK_RTTI
     const std::type_info& target_type() const noexcept override {
         return typeid(Fn);
     }
 
     void* target() noexcept override {
         return &fn;
     }
+#endif
 
     Fn fn;
 };
@@ -95,6 +99,7 @@ struct function<R(Args...)> {
 
     std::shared_ptr<fn_base<R, Args...>> impl;
 
+#ifdef BRISK_RTTI
     const std::type_info& target_type() const noexcept {
         return impl->target_type();
     }
@@ -107,6 +112,7 @@ struct function<R(Args...)> {
             return nullptr;
         }
     }
+#endif
 
     bool operator==(const function& fn) const noexcept {
         return impl == fn.impl;

include/brisk/gui/Component.hpp

@@ -34,7 +34,7 @@ namespace Brisk {
  */
 class Component : public BindingObject<Component, &uiScheduler> {
 public:
-    virtual ~Component();
+    ~Component() override {}
 
     /**
      * @brief Gets the `GUIWindow` associated with this component.

include/brisk/gui/Groups.hpp

@@ -28,33 +28,45 @@ struct SizeGroup : public WidgetGroup {
 public:
     constexpr SizeGroup(Orientation orientation) : orientation(orientation) {}
 
+    ~SizeGroup() override = default;
+
     Orientation orientation;
 
     void beforeLayout(bool dirty) final;
 };
 
 struct WidthGroup final : public SizeGroup {
     constexpr WidthGroup() : SizeGroup(Orientation::Horizontal) {}
+
+    ~WidthGroup() override = default;
 };
 
 struct HeightGroup final : public SizeGroup {
     constexpr HeightGroup() : SizeGroup(Orientation::Vertical) {}
+
+    ~HeightGroup() override = default;
 };
 
 struct VisualGroup : public WidgetGroup {
     constexpr VisualGroup(Orientation orientation) : orientation(orientation) {}
 
+    ~VisualGroup() override = default;
+
     Orientation orientation;
 
     void beforeFrame() final;
 };
 
 struct HorizontalVisualGroup final : public VisualGroup {
     constexpr HorizontalVisualGroup() : VisualGroup(Orientation::Horizontal) {}
+
+    ~HorizontalVisualGroup() override = default;
 };
 
 struct VerticalVisualGroup final : public VisualGroup {
     constexpr VerticalVisualGroup() : VisualGroup(Orientation::Vertical) {}
+
+    ~VerticalVisualGroup() override = default;
 };
 
 template <typename WidgetGroup>
@@ -71,6 +83,8 @@ class WIDGET WidgetWithGroup final : public Widget {
         endConstruction();
     }
 
+    ~WidgetWithGroup() override = default;
+
     void append(RC<Widget> widget) override {
         if (widget)
             widget->apply(&group);

include/brisk/gui/WidgetTree.hpp

@@ -35,7 +35,9 @@ class Widget;
 struct WidgetGroup {
     std::vector<Widget*> widgets;
 
-    ~WidgetGroup();
+    virtual ~WidgetGroup() {
+        clean();
+    }
 
     virtual void beforeRefresh() {}
 
@@ -46,6 +48,8 @@ struct WidgetGroup {
     virtual void beforePaint() {}
 
     virtual void afterFrame() {}
+
+    void clean();
 };
 
 using Drawable = function<void(Canvas&)>;

src/core/Binding.cpp

@@ -270,4 +270,5 @@ void Bindings::internalDisconnect(const BindingAddresses& addresses, BindDir dir
         }
     }
 }
+
 } // namespace Brisk

src/gui/Component.cpp

@@ -22,8 +22,6 @@
 
 namespace Brisk {
 
-Component::~Component() {}
-
 RC<GUIWindow> Component::window() {
     return m_window.lock();
 }

src/gui/WidgetTree.cpp

@@ -23,7 +23,7 @@
 
 namespace Brisk {
 
-WidgetGroup::~WidgetGroup() {
+void WidgetGroup::clean() {
     for (Widget* w : widgets) {
         w->removeFromGroup(this);
     }