You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have styles that are set like border(~width, ~radius, ~color) or margin4(~top, ~left, ~bottom, ~right). This convention proved to be inconvenient because:
This forces us to check which props are set. E.g if we only want to set borderWidth we'll have to mimic 'undefined' behavior for other props
It's not very discoverable. paddingHorizontal or paddingVertical is easier to understand than padding2(~h, ~v, ())
It's harder to compose. `BorderRadius is used for layout calculation, so it looked hacky when we try to pull its value from `Border.
We should split up all the things to be applied individually: paddingLeft(), paddingTop(), borderColor, borderWidth, etc.
The text was updated successfully, but these errors were encountered:
We currently have styles that are set like
border(~width, ~radius, ~color)
ormargin4(~top, ~left, ~bottom, ~right)
. This convention proved to be inconvenient because:borderWidth
we'll have to mimic 'undefined' behavior for other propspaddingHorizontal
orpaddingVertical
is easier to understand thanpadding2(~h, ~v, ())
`BorderRadius
is used for layout calculation, so it looked hacky when we try to pull its value from`Border
.We should split up all the things to be applied individually:
paddingLeft()
,paddingTop()
,borderColor
,borderWidth
, etc.The text was updated successfully, but these errors were encountered: