Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit install in run_once.sh broken #258

Open
ndiamant opened this issue May 12, 2020 · 0 comments
Open

pre-commit install in run_once.sh broken #258

ndiamant opened this issue May 12, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@ndiamant
Copy link
Contributor

What
./scripts/run_once.sh does not install pre-commit correctly.

Why
Nice to have pre-commit on VMs automatically.

How
This is what happens now:

Installing collected packages: pre-commit
  WARNING: The scripts pre-commit, pre-commit-validate-config and pre-commit-validate-manifest are installed in '/home/nate/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed pre-commit-2.4.0
./scripts/vm_launch/run_once.sh: line 15: pre-commit: command not found

Should be easy-ish to add pre-commit to $PATH automatically or something.

Acceptance Criteria
run_once.sh works

@ndiamant ndiamant added the bug Something isn't working label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant