Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat search #52

Merged
merged 18 commits into from
Jun 16, 2021
Merged

Feat search #52

merged 18 commits into from
Jun 16, 2021

Conversation

mcmcgrath13
Copy link
Contributor

@mcmcgrath13 mcmcgrath13 commented May 27, 2021 •
edited
Loading

  • Use lunr to index our pages on generate
  • Also scrape/index the docs sites on generate (it's slow, so doing it on build would be really annoying...)
  • Search bar is an inline one, not a separate result page

To do:

  • look into making scraping faster
  • styling for the results
  • limit the results
  • external links not going anywhere on click
  • Make mobile friendly
  • Fix bug with hitting enter

@github-actions
Copy link

github-actions bot commented May 27, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit a601603):

https://qa-ccv-brown-edu--pr52-feat-search-fi2k0xul.web.app

(expires Tue, 22 Jun 2021 21:29:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@mcmcgrath13 mcmcgrath13 requested review from ashleysyg, mirestrepo and paulstey and removed request for ashleysyg June 7, 2021 15:19
@mcmcgrath13 mcmcgrath13 marked this pull request as ready for review June 7, 2021 15:19
mirestrepo
mirestrepo approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@mirestrepo mirestrepo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💪
One question though. The color of blue links became lighter. See https://ccv-brown-edu.web.app for contrast on About/Documentation/Blog.. was that intended?

@mirestrepo
Copy link
Member

mirestrepo commented Jun 15, 2021 •
edited by mcmcgrath13
Loading

  • link color
  • x to clear search

mirestrepo
mirestrepo reviewed Jun 16, 2021
View reviewed changes
pages/index.vue
@@ -36,7 +36,7 @@ export default {
},
async fetch() {
// example to prove out the client-only rendering
const num = Math.floor(Math.random() * 10);
const num = Math.floor(Math.random() * 10 + 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

mirestrepo
mirestrepo approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@mirestrepo mirestrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mirestrepo
Copy link
Member

I created #54 to one day remind us of full fledge search engine

@mcmcgrath13 mcmcgrath13 merged commit c9cf9f1 into main Jun 16, 2021
@mcmcgrath13 mcmcgrath13 deleted the feat-search branch June 16, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirestrepo mirestrepo mirestrepo approved these changes

@ashleysyg ashleysyg Awaiting requested review from ashleysyg

@paulstey paulstey Awaiting requested review from paulstey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmcgrath13 @mirestrepo