Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: initialize navbar #19

Closed
wants to merge 19 commits into from
Closed

Feat: initialize navbar #19

wants to merge 19 commits into from

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Oct 22, 2024

Includes the main routes for the site, but no sub-routes as of yet. Would love to have a conversation about accessible subroute design.

To see what the Navbar link looks like when it is the active route, look at the "About" page, which is the only implemented route at this time.

Copy link

github-actions bot commented Oct 22, 2024

Visit the preview URL for this PR (updated for commit c5ad147):

https://ccv-website-next--pr19-feat-navbar-n3i5udh5.web.app

(expires Wed, 13 Nov 2024 21:02:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 809aa2d3a6cfe026c3c7417c932015a8f1d9ec89

@hetd54 hetd54 linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link
Collaborator

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The active route for about looks good! And we can talk about subroutes today at our website meeting!

components/NavLinks.tsx Outdated Show resolved Hide resolved
@hetd54 hetd54 requested a review from eldu November 6, 2024 20:22
@hetd54
Copy link
Collaborator Author

hetd54 commented Nov 25, 2024

After discussing, we want subroutes! Closing this branch

@hetd54 hetd54 closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar Component
2 participants