Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup firebase #2

Merged
merged 7 commits into from
Aug 8, 2024
Merged

chore: setup firebase #2

merged 7 commits into from
Aug 8, 2024

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Aug 8, 2024

No description provided.

Copy link

github-actions bot commented Aug 8, 2024

Visit the preview URL for this PR (updated for commit 3b23ac8):

https://ccv-website-next--pr2-chore-setup-firebase-tdokgk37.web.app

(expires Thu, 15 Aug 2024 18:56:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 809aa2d3a6cfe026c3c7417c932015a8f1d9ec89

@hetd54 hetd54 requested review from eldu, anna-murphy and s-bessey August 8, 2024 18:41
Copy link
Collaborator

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More so a question

When I click on the preview link, it's blank which is like how the /pages/index.tsx looks however in the public/index.html the html has a div that says "Firebase Hosting Setup Complete"

Is there supposed to be a public/index.html file? I feel like I usually just see favicons.

@hetd54
Copy link
Collaborator Author

hetd54 commented Aug 8, 2024

More so a question

When I click on the preview link, it's blank which is like how the /pages/index.tsx looks however in the public/index.html the html has a div that says "Firebase Hosting Setup Complete"

Is there supposed to be a public/index.html file? I feel like I usually just see favicons.

Good catch -- this was created when I have the public folder as the build folder erroneously. Removed!

@hetd54 hetd54 merged commit 3583a3a into main Aug 8, 2024
2 checks passed
@hetd54 hetd54 deleted the chore-setup-firebase branch August 8, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants