Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AbortSignal #79

Closed
feross opened this issue Dec 30, 2020 · 4 comments
Closed

Support AbortSignal #79

feross opened this issue Dec 30, 2020 · 4 comments

Comments

@feross
Copy link
Member

feross commented Dec 30, 2020

An AbortSignal can be used to cancel waiting on events. See: https://nodejs.org/api/events.html#events_events_on_emitter_eventname_options

@feross
Copy link
Member Author

feross commented Dec 30, 2020

Nevermind, this is dependent on first implementing events.on. See: #76

@feross feross closed this as completed Dec 30, 2020
@benjamingr
Copy link

@feross would it help if Node just vendored events independently (like readable stream)?

It looks like events.js doesn't actually have any non-constant dependencies (other than event_target which is also pretty easy to fix)

@goto-bus-stop
Copy link
Member

@benjamingr Part of the goal of this package is also to be compatible with old browsers (except for the Promise functions). If events could be vendored independently and compiled down for browsers just like readable-stream is, I think that would be amazing :)

@benjamingr
Copy link

Opened nodejs/node#37435 - let me know if this is something you'd like to collaborate on.

It's basically a script that "rips out" events from Node's lib folder and shims core-related things (not many)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants