Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with Node.js master #38

Open
BridgeAR opened this issue May 6, 2019 · 1 comment
Open

Sync with Node.js master #38

BridgeAR opened this issue May 6, 2019 · 1 comment

Comments

@BridgeAR
Copy link
Member

BridgeAR commented May 6, 2019

This is just a meta issue to update the whole module. So far it supports parts and other things are missing or somewhat outdated. It would be good to sync the whole project. One of the things that we should look into is what Browser support should be achieved. I personally would like to skip IE support. It is pretty hard to backport all changes that are necessary to support the Internet Explorer 11 (even though the current worldwide usage is still around 3%).

@goto-bus-stop
Copy link
Member

goto-bus-stop commented May 6, 2019

IMO we should not crash on IE11, but output differences in util.inspect/util.format('%o') are okay. those are unlikely to be end-user-facing and developers who are targeting IE11- will be able to deal with differences in debug output. For isDeepStrictEqual, i guess it would also be a best-effort implementation(?), but we can caution users if it doesn't work with polyfilled ES6 Set/Map for example.

During the nearform grant for browserify I worked on updating util.inspect here: https://github.com/browserify/node-util/tree/inspect I don't know if that is a useful starting point, a good chunk of it is just worse implementations of the new util.types functions :)

I don't remember what the status is on most of the updates I was trying to do to this module, and I'm mid-move right now so not yet sure if/when i'll have time to dig into it! Anyway, if you (or someone else) submit a PR that would obsolete some of my unfinished work that'd be totally fine

When we have all the missing stuff, we should bump this to 1.0 finally haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants