Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graceful stop #27

Open
wants to merge 4 commits into
base: review-branch
Choose a base branch
from
Open

Add graceful stop #27

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29e2904
Add graceful stop
dinsaw Mar 24, 2022
a4a50cb
Add stop.tt
dinsaw Mar 24, 2022
31ec38f
Fix spawn logic
dinsaw Mar 24, 2022
7cba3ab
Add condition for graceful stop watch
dinsaw Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const WORKER_CNT = config.workerVal;
const activeWorkers = [];

const RESTART_FILE = path.join(codeDir, 'tmp/restart.txt');
const STOP_FILE = path.join(codeDir, 'tmp/stop.txt');
let stopCalled = false;

const forceKill = (worker) => {
if (!worker.isDead()) {
Expand Down Expand Up @@ -52,7 +54,15 @@ if (cluster.isMaster) {
logger.info(
`worker ${worker.process.pid} died with signal ${signal} code ${code}`
);
if (activeWorkers.length == 0) spawnNewWorkers();
if (stopCalled) {
if (activeWorkers.length == 0) {
logger.info(
`All workers stopped. Exiting master process ${process.pid}`
);
process.exit(0);
}
}
if (activeWorkers.length == 0 && !stopCalled) spawnNewWorkers();
});

spawnNewWorkers();
Expand All @@ -65,6 +75,14 @@ if (cluster.isMaster) {
spawnNewWorkers();
}
});
watch(STOP_FILE, () => {
logger.info(`Stopping cluster gracefully`)
stopCalled = true;
if (Date.now() > currTime) {
currTime = Date.now();
disconnectOldWorkers();
}
});
} else {
const proxy = new Proxy();
cluster.worker.on('disconnect', () => {
Expand Down
Empty file added tmp/stop.txt
View file
Open in desktop
Empty file.