Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): queue diff tail len sync #474

Closed

Conversation

drmick
Copy link
Member

@drmick drmick commented Nov 25, 2024

No description provided.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 20.79208% with 80 lines in your changes missing coverage. Please review.

Project coverage is 42.95%. Comparing base (4755326) to head (48a7ea0).
Report is 2 commits behind head on feature/queue-diff-len-calc.

Files with missing lines Patch % Lines
collator/src/collator/do_collate/mod.rs 0.00% 34 Missing ⚠️
collator/src/collator/do_collate/finalize.rs 0.00% 21 Missing ⚠️
collator/src/internal_queue/queue.rs 41.66% 13 Missing and 1 partial ⚠️
collator/src/queue_adapter.rs 0.00% 6 Missing ⚠️
core/src/block_strider/subscriber/ps_subscriber.rs 0.00% 2 Missing ⚠️
collator/src/manager/mod.rs 0.00% 1 Missing ⚠️
...e/src/store/persistent_state/queue_state/reader.rs 66.66% 1 Missing ⚠️
storage/src/store/persistent_state/tests.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/queue-diff-len-calc     #474      +/-   ##
===============================================================
- Coverage                        43.00%   42.95%   -0.05%     
===============================================================
  Files                              266      266              
  Lines                            46484    46530      +46     
  Branches                         46484    46530      +46     
===============================================================
  Hits                             19989    19989              
- Misses                           25413    25457      +44     
- Partials                          1082     1084       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmick drmick force-pushed the feature/queue-diff-len-calc branch 2 times, most recently from 19b3f14 to 5b35546 Compare November 28, 2024 13:13
@drmick drmick closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant