Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final code feedback #2

Open
tov opened this issue Mar 23, 2020 · 0 comments
Open

Final code feedback #2

tov opened this issue Mar 23, 2020 · 0 comments

Comments

@tov
Copy link

tov commented Mar 23, 2020

Looks like you’ve done an impressive job here. There are two things limiting this to a ✓: 1) Your testing appears perfunctory—this is not what testing well looks like. 2) Most of the methods are undocumented! Nice job overall, though :)

Hope you both stay healthy and enjoy your spring breaks.

J
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tov