Skip to content

Commit

Permalink
fix col name
Browse files Browse the repository at this point in the history
  • Loading branch information
karakanb committed Jul 11, 2024
1 parent 34a04f7 commit e020fc9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pkg/bigquery/materialization.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func buildIncrementalQuery(asset *pipeline.Asset, query string) (string, error)
fmt.Sprintf("DECLARE %s array<%s>", declaredVarName, foundCol.Type),
"BEGIN TRANSACTION",
fmt.Sprintf("CREATE TEMP TABLE %s AS %s", tempTableName, query),
fmt.Sprintf("SET %s = (SELECT array_agg(distinct dt) FROM %s)", declaredVarName, tempTableName),
fmt.Sprintf("SET %s = (SELECT array_agg(distinct %s) FROM %s)", declaredVarName, mat.IncrementalKey, tempTableName),
fmt.Sprintf("DELETE FROM %s WHERE %s in unnest(%s)", asset.Name, mat.IncrementalKey, declaredVarName),
fmt.Sprintf("INSERT INTO %s SELECT * FROM %s", asset.Name, tempTableName),
"COMMIT TRANSACTION",
Expand Down
8 changes: 4 additions & 4 deletions pkg/bigquery/materialization_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,18 +160,18 @@ func TestMaterializer_Render(t *testing.T) {
Materialization: pipeline.Materialization{
Type: pipeline.MaterializationTypeTable,
Strategy: pipeline.MaterializationStrategyDeleteInsert,
IncrementalKey: "dt",
IncrementalKey: "somekey",
},
Columns: []pipeline.Column{
{Name: "dt", Type: "date"},
{Name: "somekey", Type: "date"},
},
},
query: "SELECT 1",
want: "^DECLARE distinct_keys.+ array<date>;\n" +
"BEGIN TRANSACTION;\n" +
"CREATE TEMP TABLE __bruin_tmp_.+ AS SELECT 1;\n" +
"SET distinct_keys_.+ = \\(SELECT array_agg\\(distinct dt\\) FROM __bruin_tmp_.+\\);\n" +
"DELETE FROM my\\.asset WHERE dt in unnest\\(distinct_keys.+\\);\n" +
"SET distinct_keys_.+ = \\(SELECT array_agg\\(distinct somekey\\) FROM __bruin_tmp_.+\\);\n" +
"DELETE FROM my\\.asset WHERE somekey in unnest\\(distinct_keys.+\\);\n" +
"INSERT INTO my\\.asset SELECT \\* FROM __bruin_tmp.+;\n" +
"COMMIT TRANSACTION;$",
},
Expand Down

0 comments on commit e020fc9

Please sign in to comment.