Skip to content

Commit

Permalink
change rules
Browse files Browse the repository at this point in the history
  • Loading branch information
terzioglub committed Feb 28, 2025
1 parent 51887ef commit e4121bd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/lint/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -669,10 +669,10 @@ func EnsureMaterializationValuesAreValidForSingleAsset(ctx context.Context, p *p
}

if asset.Materialization.IncrementalKey != "" &&
asset.Materialization.Strategy != pipeline.MaterializationStrategyDeleteInsert {
asset.Materialization.Strategy != pipeline.MaterializationStrategyDeleteInsert || asset.Materialization.Strategy != pipeline.MaterializationStrategyTimeInterval {
issues = append(issues, &Issue{
Task: asset,
Description: "Incremental key is only supported with 'delete+insert' strategy",
Description: "Incremental key is only supported with 'delete+insert' or 'time_interval' strategies.",
})
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/lint/rules_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1348,7 +1348,7 @@ func TestEnsureMaterializationValuesAreValid(t *testing.T) {
},
wantErr: assert.NoError,
want: []string{
"Incremental key is only supported with 'delete+insert' strategy",
"Incremental key is only supported with 'delete+insert' or 'time_interval' strategies",
},
},
{
Expand Down

0 comments on commit e4121bd

Please sign in to comment.