From e4121bd0adaf1149ffe1aaa3e0591da5e68f5d73 Mon Sep 17 00:00:00 2001 From: Baris Terzioglu Date: Fri, 28 Feb 2025 11:36:53 +0100 Subject: [PATCH] change rules --- pkg/lint/rules.go | 4 ++-- pkg/lint/rules_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/lint/rules.go b/pkg/lint/rules.go index 71b81f444..9f907f0c6 100644 --- a/pkg/lint/rules.go +++ b/pkg/lint/rules.go @@ -669,10 +669,10 @@ func EnsureMaterializationValuesAreValidForSingleAsset(ctx context.Context, p *p } if asset.Materialization.IncrementalKey != "" && - asset.Materialization.Strategy != pipeline.MaterializationStrategyDeleteInsert { + asset.Materialization.Strategy != pipeline.MaterializationStrategyDeleteInsert || asset.Materialization.Strategy != pipeline.MaterializationStrategyTimeInterval { issues = append(issues, &Issue{ Task: asset, - Description: "Incremental key is only supported with 'delete+insert' strategy", + Description: "Incremental key is only supported with 'delete+insert' or 'time_interval' strategies.", }) } diff --git a/pkg/lint/rules_test.go b/pkg/lint/rules_test.go index 1ec2f3a49..3dfbfc0c4 100644 --- a/pkg/lint/rules_test.go +++ b/pkg/lint/rules_test.go @@ -1348,7 +1348,7 @@ func TestEnsureMaterializationValuesAreValid(t *testing.T) { }, wantErr: assert.NoError, want: []string{ - "Incremental key is only supported with 'delete+insert' strategy", + "Incremental key is only supported with 'delete+insert' or 'time_interval' strategies", }, }, {