Merge pull request #105 from bryantbhowell/5.2.1

5.2.1 - fixes error in permissions settings code
bryanthowell-tableau · Mar 11, 2021 · 42dda58 · 42dda58
2 parents 1cb0b69 + 5b724e5
commit 42dda58
Show file tree

Hide file tree

Showing 68 changed files with 6 additions and 6 deletions.
diff --git a/.gitattributes b/.gitattributes
diff --git a/.gitignore b/.gitignore
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/License.txt b/License.txt
diff --git a/README.md b/README.md
diff --git a/__init__.py b/__init__.py
diff --git a/examples/archive_site.py b/examples/archive_site.py
diff --git a/examples/create_site_sample.py b/examples/create_site_sample.py
diff --git a/examples/hyper_api_samples.py b/examples/hyper_api_samples.py
diff --git a/examples/limited_rest_api_wrapping_tableau_rest_api.py b/examples/limited_rest_api_wrapping_tableau_rest_api.py
diff --git a/examples/modifying_users_immediately_before_sso.py b/examples/modifying_users_immediately_before_sso.py
diff --git a/examples/move_extracts_from_server_to_server.py b/examples/move_extracts_from_server_to_server.py
diff --git a/examples/permissions_auditing.py b/examples/permissions_auditing.py
diff --git a/examples/replicate_site_structure_sample.py b/examples/replicate_site_structure_sample.py
diff --git a/examples/template_publish_sample.py b/examples/template_publish_sample.py
diff --git a/examples/test_suite_all_add_update_delete_publish_tableau_server_rest.py b/examples/test_suite_all_add_update_delete_publish_tableau_server_rest.py
diff --git a/examples/test_suite_all_querying_tableau_rest_api_connection.py b/examples/test_suite_all_querying_tableau_rest_api_connection.py
diff --git a/examples/test_suite_all_querying_tableau_server_rest.py b/examples/test_suite_all_querying_tableau_server_rest.py
diff --git a/examples/test_suite_tableau_documents.py b/examples/test_suite_tableau_documents.py
diff --git a/examples/user_sync_sample.py b/examples/user_sync_sample.py
diff --git a/logger.py b/logger.py
diff --git a/logging_methods.py b/logging_methods.py
diff --git a/requirements.txt b/requirements.txt
diff --git a/rest_tokens_manager.py b/rest_tokens_manager.py
diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 setup(
     name='tableau_tools',
     python_requires='>=3.6',
-    version='5.2.0',
+    version='5.2.1',
     packages=['tableau_tools', 'tableau_tools.tableau_rest_api', 'tableau_tools.tableau_documents',
               'tableau_tools.examples', 'tableau_tools.tableau_rest_api.methods'],
     url='https://github.com/bryantbhowell/tableau_tools',

diff --git a/tabcmd.py b/tabcmd.py
diff --git a/tableau_documents/__init__.py b/tableau_documents/__init__.py
diff --git a/tableau_documents/hyper_file_generator.py b/tableau_documents/hyper_file_generator.py
diff --git a/tableau_documents/table_relations.py b/tableau_documents/table_relations.py
diff --git a/tableau_documents/tableau_columns.py b/tableau_documents/tableau_columns.py
diff --git a/tableau_documents/tableau_connection.py b/tableau_documents/tableau_connection.py
diff --git a/tableau_documents/tableau_datasource.py b/tableau_documents/tableau_datasource.py
diff --git a/tableau_documents/tableau_document.py b/tableau_documents/tableau_document.py
diff --git a/tableau_documents/tableau_file.py b/tableau_documents/tableau_file.py
diff --git a/tableau_documents/tableau_parameters.py b/tableau_documents/tableau_parameters.py
diff --git a/tableau_documents/tableau_workbook.py b/tableau_documents/tableau_workbook.py
diff --git a/tableau_emailer.py b/tableau_emailer.py
diff --git a/tableau_exceptions.py b/tableau_exceptions.py
diff --git a/tableau_http.py b/tableau_http.py
diff --git a/tableau_repository.py b/tableau_repository.py
diff --git a/tableau_rest_api/__init__.py b/tableau_rest_api/__init__.py
diff --git a/tableau_rest_api/methods/__init__.py b/tableau_rest_api/methods/__init__.py
diff --git a/tableau_rest_api/methods/_lookups.py b/tableau_rest_api/methods/_lookups.py
diff --git a/tableau_rest_api/methods/alert.py b/tableau_rest_api/methods/alert.py
diff --git a/tableau_rest_api/methods/datasource.py b/tableau_rest_api/methods/datasource.py
diff --git a/tableau_rest_api/methods/extract.py b/tableau_rest_api/methods/extract.py
diff --git a/tableau_rest_api/methods/favorites.py b/tableau_rest_api/methods/favorites.py
diff --git a/tableau_rest_api/methods/flow.py b/tableau_rest_api/methods/flow.py
diff --git a/tableau_rest_api/methods/group.py b/tableau_rest_api/methods/group.py
diff --git a/tableau_rest_api/methods/metadata.py b/tableau_rest_api/methods/metadata.py
diff --git a/tableau_rest_api/methods/project.py b/tableau_rest_api/methods/project.py
diff --git a/tableau_rest_api/methods/rest_api_base.py b/tableau_rest_api/methods/rest_api_base.py
diff --git a/tableau_rest_api/methods/revision.py b/tableau_rest_api/methods/revision.py
diff --git a/tableau_rest_api/methods/schedule.py b/tableau_rest_api/methods/schedule.py
diff --git a/tableau_rest_api/methods/site.py b/tableau_rest_api/methods/site.py
diff --git a/tableau_rest_api/methods/subscription.py b/tableau_rest_api/methods/subscription.py
diff --git a/tableau_rest_api/methods/user.py b/tableau_rest_api/methods/user.py
diff --git a/tableau_rest_api/methods/webhooks.py b/tableau_rest_api/methods/webhooks.py
diff --git a/tableau_rest_api/methods/workbook.py b/tableau_rest_api/methods/workbook.py
diff --git a/tableau_rest_api/permissions.py b/tableau_rest_api/permissions.py
diff --git a/tableau_rest_api/published_content.py b/tableau_rest_api/published_content.py
@@ -456,17 +456,17 @@ def set_permissions_by_permissions_obj_list(self, new_permissions_obj_list):
                 # Check if there are any existing capabilities on the object
                 if cur_obj.luid == new_permissions_obj.luid:
                     # Find if anything is set already, add to deletion queue
-                    need_to_change = self.are_capabilities_obj_dicts_identical(
+                    are_identical = self.are_capabilities_obj_dicts_identical(
                         cur_obj.get_capabilities_dict(), new_permissions_obj.get_capabilities_dict()
                     )
-                    self.log("Existing permissions found for luid {}. Are there differences? {}".format(cur_obj.luid,
-                                                                                                         str(need_to_change)))
+                    self.log("Existing permissions found for luid {}. Are they the same? {}".format(cur_obj.luid,
+                                                                                                         str(are_identical)))
                     # Delete all existing permissions
-                    if need_to_change is True:
+                    if are_identical is False:
                         self.log("Removing existing permissions for luid {}".format(cur_obj.luid))
                         self.delete_permissions_by_permissions_obj_list([cur_obj, ])
 
-                    if need_to_change is False:
+                    if are_identical is True:
                         self.log('No changes necessary, skipping update for quicker performance')
                         # self.end_log_block()
                         continue

diff --git a/tableau_rest_api/rest_json_request.py b/tableau_rest_api/rest_json_request.py
diff --git a/tableau_rest_api/rest_xml_request.py b/tableau_rest_api/rest_xml_request.py
diff --git a/tableau_rest_api/sort.py b/tableau_rest_api/sort.py
diff --git a/tableau_rest_api/url_filter.py b/tableau_rest_api/url_filter.py
diff --git a/tableau_rest_api_connection.py b/tableau_rest_api_connection.py
diff --git a/tableau_rest_xml.py b/tableau_rest_xml.py
diff --git a/tableau_server_rest.py b/tableau_server_rest.py