Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tableau_file.py] algorithm to kill extension fails #92

Open
martijn1247812 opened this issue May 29, 2020 · 1 comment
Open

[tableau_file.py] algorithm to kill extension fails #92

martijn1247812 opened this issue May 29, 2020 · 1 comment

Comments

@martijn1247812
Copy link

The line in def save_new_file:
new_filename = new_filename_no_extension.split('.')[0] # simple algorithm to kill extension

fails for current folder notation , like '.\temp\Sandbox_report.twb'

Probably i should use the current folder, but that makes a mess of my project folder. also the check later in the function looks for existing files in the current directory (and not my '.\temp\' )
Maybe a good idea to allow also a path for new_filename_no_extention ?

@martijn1247812
Copy link
Author

ok, back again. I'm not a programmer, but I also see difference in de class TWB and TWBX in save_new_file. Major things: TWBX returns filename and TWB not. TWB has option to add save_to_directory, however does not prevent overwriting (this logic is before???)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant