Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lose the pink in the window buttons #14

Open
anasik opened this issue Dec 26, 2016 · 5 comments
Open

Lose the pink in the window buttons #14

anasik opened this issue Dec 26, 2016 · 5 comments

Comments

@anasik
Copy link

anasik commented Dec 26, 2016

image
See that pink highlight? It has absolutely no reason to be here. We need the friendly shade of orange.

Also, I would prefer it if, instead of the fill changing from white to pink or orange, the background changed from transparent to orange, on hover. Like this:
image

@anasik
Copy link
Author

anasik commented Jan 1, 2017

I must add that I know that in the original concept:

  • The buttons were on the right.
  • The buttons weren't anything like this.

However, this time, we must make an exception. Charmander concept, the way I see it, was about beautifying unity while maintaining it's design. It is supposed to be an upgrade. I don't see why the window buttons need to move. And I don't see why they should be white.

@btd1337
Copy link
Owner

btd1337 commented Jan 2, 2017

Hey guy,

Can I add you as a collaborator to the project?

@anasik
Copy link
Author

anasik commented Jan 3, 2017

That's your call.

@rocketinventor
Copy link

@anasik I think the original idea of the project was to replicate the charmander concept as faithfully as possible. Many people would like to see this vision accomplished (as evidenced by the stars and comments about how to make it like the concept) and many people would like for the buttons to be on the right side.

Why do we need to make an exception? What's wrong with right-side buttons? If you start changing it, it becomes a version of your vision, and not the actual charmander concept.

@anasik
Copy link
Author

anasik commented Jan 8, 2017

When I said "original concept", I was talking about the charmander itself and not this repo.

I'll tell you why we need to make an exception. The problem with right-side buttons is that at that one point, charmander appears to be going against itself. The beauty of charmander, as I have made clear before, it upgraded everything in unity and was visually appealing, while at the same time, it didn't seem to have changed anything. But, for some reason, the window title-bars, in that concept, are completely revamped. They are all gray, the buttons are on the right. In unity it's the same color as the gnome-bar.
I do, however, understand that they didn't make any commitments about not wanting to change the title-bar and I also understand if you don't feel like making the exception I demanded.

In which case, you do realize that to have title-bars as shown in the concept, you're going to have to do some more work. As you can see, the navigation buttons, the tabs and the window buttons in the browser shown are in the same bar.. Also, there is very little padding. On the whole, the bar has more height, it has a uniform background.

Here's an idea, while you work on this, can you change the window buttons to the orange I requested? So that the theme looks better until it can look perfect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants