Merge pull request #2141 from bugsnag/fix-electron-v8

Fix electron v8
bugsnag · Jul 24, 2024 · 0c0fd2e · 0c0fd2e
2 parents 6118ca0 + 37b6b0d
commit 0c0fd2e
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 24 deletions.
diff --git a/test/electron/features/support/utils/payload-matchers.js b/test/electron/features/support/utils/payload-matchers.js
@@ -61,7 +61,7 @@ const compareArray = (expected, actual, path) => {
   let found = 0 // counts matching indices and ensures ordering is correct
   const expectToFind = expected.length
   const keyPath = [path, '{index}'].join('.')
-  let differences
+  let differences = []
   for (const item of actual) {
     if (found === expectToFind) {
       break

diff --git a/test/electron/fixtures/app/src/main.js b/test/electron/fixtures/app/src/main.js
@@ -54,7 +54,7 @@ function makeSimpleGetRequest (fail = false) {
 }
 
 function networkRequestError () {
-  const request = net.request('http://locahost:65536/')
+  const request = net.request('http://locahost:994/')
   request.on('error', notify)
   request.end()
 }

diff --git a/test/electron/fixtures/events/main/breadcrumbs/network/error.json b/test/electron/fixtures/events/main/breadcrumbs/network/error.json
@@ -61,7 +61,7 @@
           "timestamp": "{TIMESTAMP}",
           "metaData": {
             "method": "GET",
-            "url": "http://locahost:65536/",
+            "url": "http://locahost:994/",
             "status": "{TYPE:undefined}",
             "duration": "{TYPE:number}"
           }
@@ -71,13 +71,7 @@
         {
           "errorMessage": "something bad",
           "errorClass": "ReferenceError",
-          "stacktrace": [{
-            "file": "./src/errors.js",
-            "lineNumber": 18,
-            "code": {
-              "1": "{TYPE:string}"
-            }
-          }],
+          "stacktrace": [],
           "type": "electronnodejs"
         }
       ]

diff --git a/test/electron/fixtures/events/main/breadcrumbs/network/get-failure.json b/test/electron/fixtures/events/main/breadcrumbs/network/get-failure.json
@@ -71,13 +71,7 @@
         {
           "errorMessage": "something bad",
           "errorClass": "ReferenceError",
-          "stacktrace": [{
-            "file": "./src/errors.js",
-            "lineNumber": 18,
-            "code": {
-              "1": "{TYPE:string}"
-            }
-          }],
+          "stacktrace": [],
           "type": "electronnodejs"
         }
       ]

diff --git a/test/electron/fixtures/events/main/breadcrumbs/network/get-success.json b/test/electron/fixtures/events/main/breadcrumbs/network/get-success.json
@@ -71,13 +71,7 @@
         {
           "errorMessage": "something bad",
           "errorClass": "ReferenceError",
-          "stacktrace": [{
-            "file": "./src/errors.js",
-            "lineNumber": 18,
-            "code": {
-              "1": "{TYPE:string}"
-            }
-          }],
+          "stacktrace": [],
           "type": "electronnodejs"
         }
       ]

diff --git a/test/electron/local-npm-config.yml b/test/electron/local-npm-config.yml
@@ -1,4 +1,5 @@
 storage: ../.verdaccio
+max_body_size: 25mb
 auth:
   htpasswd:
     file: ../.verdaccio/htpasswd