chore: 👷 remove use of legacy peer dependencies

bugsnag · Oct 2, 2024 · 398e3e6 · 398e3e6
1 parent 81a2e90
commit 398e3e6
Show file tree

Hide file tree

Showing 26 changed files with 100 additions and 47 deletions.
diff --git a/.npmrc b/.npmrc
diff --git a/bin/local-test-util b/bin/local-test-util
@@ -133,7 +133,6 @@ async function installNotifiers (notifier) {
     `install`,
     `--no-package-lock`,
     `--no-save`,
-    `--legacy-peer-deps`
   ].concat(notifier
     ? [
       `../../../../bugsnag-${notifier}-${require(`../packages/${notifier}/package.json`).version}.tgz`
@@ -156,7 +155,6 @@ async function installNgNotifier (notifier) {
     `install`,
     `--no-package-lock`,
     `--no-save`,
-    `--legacy-peer-deps`,
     `../../../../../../bugsnag-browser-${require('../packages/browser/package.json').version}.tgz`,
     `../../../../../../bugsnag-js-${require('../packages/js/package.json').version}.tgz`,
     `../../../../../../bugsnag-node-${require('../packages/node/package.json').version}.tgz`,

diff --git a/dockerfiles/Dockerfile.browser b/dockerfiles/Dockerfile.browser
@@ -11,7 +11,7 @@ ADD min_packages.tar .
 COPY bin ./bin
 COPY packages ./packages
 
-RUN npm install --legacy-peer-deps
+RUN npm install
 RUN npm run build
 
 RUN npm pack --verbose packages/js/
@@ -24,14 +24,14 @@ RUN npm pack --verbose packages/web-worker/
 
 COPY test/browser/features test/browser/features
 WORKDIR /app/test/browser/features/fixtures
-RUN npm install --no-package-lock --no-save --legacy-peer-deps \
+RUN npm install --no-package-lock --no-save \
 ../../../../bugsnag-browser-*.tgz \
 ../../../../bugsnag-plugin-react-*.tgz \
 ../../../../bugsnag-plugin-vue-*.tgz \
 ../../../../bugsnag-web-worker-*.tgz
 
 WORKDIR plugin_angular/ng
-RUN npm install --no-package-lock --no-save --legacy-peer-deps \
+RUN npm install --no-package-lock --no-save \
   ../../../../../../bugsnag-plugin-angular-*.tgz  \
   ../../../../../../bugsnag-node-*.tgz \
   ../../../../../../bugsnag-browser-*.tgz \
@@ -40,7 +40,7 @@ RUN npm install --no-package-lock --no-save --legacy-peer-deps \
 # install the dependencies and build each fixture
 WORKDIR /app/test/browser/features/fixtures
 RUN find . -name package.json -type f -mindepth 2 -maxdepth 3 ! -path "./node_modules/*" | \
-  xargs -I % bash -c 'cd `dirname %` && npm install --no-package-lock --legacy-peer-deps && npm run build'
+  xargs -I % bash -c 'cd `dirname %` && npm install --no-package-lock && npm run build'
 
 # once the fixtures are built we no longer need node_modules and
 # it makes the COPY later on much faster if we don't have them

diff --git a/dockerfiles/Dockerfile.ci b/dockerfiles/Dockerfile.ci
@@ -13,5 +13,5 @@ COPY scripts ./scripts
 COPY test ./test
 COPY packages ./packages
 
-RUN npm install --unsafe-perm --legacy-peer-deps
+RUN npm install --unsafe-perm
 RUN npm run build
diff --git a/dockerfiles/Dockerfile.node b/dockerfiles/Dockerfile.node
@@ -11,7 +11,7 @@ ADD min_packages.tar .
 COPY bin ./bin
 COPY packages ./packages
 
-RUN npm install --legacy-peer-deps
+RUN npm install
 RUN npm run build
 
 RUN npm pack --verbose packages/node/

diff --git a/dockerfiles/Dockerfile.react-native-android-builder-java-11-node-16 b/dockerfiles/Dockerfile.react-native-android-builder-java-11-node-16
@@ -14,7 +14,6 @@ ARG REG_NPM_EMAIL
 RUN echo "_auth=$REG_BASIC_CREDENTIAL" >> ~/.npmrc
 RUN echo "email=$REG_NPM_EMAIL" >> ~/.npmrc
 RUN echo "always-auth=true" >> ~/.npmrc
-RUN echo "legacy-peer-deps=true" >> ~/.npmrc
 
 # gradle / artifactory auth
 ARG MAVEN_REPO_URL

diff --git a/dockerfiles/Dockerfile.react-native-cli-android-builder b/dockerfiles/Dockerfile.react-native-cli-android-builder
@@ -22,7 +22,6 @@ RUN echo "registry=$REGISTRY_URL" >> ~/.npmrc
 RUN echo "_auth=$REG_BASIC_CREDENTIAL" >> ~/.npmrc
 RUN echo "email=$REG_NPM_EMAIL" >> ~/.npmrc
 RUN echo "always-auth=true" >> ~/.npmrc
-RUN echo "legacy-peer-deps=true" >> ~/.npmrc
 
 # Now copy in all the files needed to build
 COPY .git .git

diff --git a/package-lock.json b/package-lock.json
diff --git a/scripts/react-native-cli-helper.js b/scripts/react-native-cli-helper.js
@@ -26,7 +26,7 @@ module.exports = {
       common.run('npm install', true)
 
       // Install and run the CLI
-      const installCommand = `npm install @bugsnag/react-native-cli@${version} --legacy-peer-deps`
+      const installCommand = `npm install @bugsnag/react-native-cli@${version}`
       common.run(installCommand, true)
 
       // Use Expect to run the init command interactively
@@ -79,7 +79,7 @@ module.exports = {
       common.run('npm install', true)
 
       // Install and run the CLI
-      const installCommand = `npm install @bugsnag/react-native-cli@${version} --legacy-peer-deps`
+      const installCommand = `npm install @bugsnag/react-native-cli@${version}`
       common.run(installCommand, true)
 
       // Use Expect to run the init command interactively

diff --git a/scripts/react-native-helper.js b/scripts/react-native-helper.js
@@ -32,7 +32,7 @@ module.exports = {
       common.run(`npm install --registry ${registryUrl}`, true)
 
       // Install notifier
-      const command = `npm install @bugsnag/react-native@${version}  --registry ${registryUrl} --legacy-peer-deps`
+      const command = `npm install @bugsnag/react-native@${version}  --registry ${registryUrl}`
       common.run(command, true)
 
       // Install react-native-file-access
@@ -98,7 +98,7 @@ module.exports = {
 
       // Install notifier
       console.log(`Installing notifier: ${version}`)
-      const command = `npm install @bugsnag/react-native@${version}  --registry ${registryUrl} --legacy-peer-deps`
+      const command = `npm install @bugsnag/react-native@${version}  --registry ${registryUrl}`
       common.run(command, true)
 
       // Install react-native-file-access

diff --git a/test/electron/features/support/app.js b/test/electron/features/support/app.js
@@ -4,7 +4,7 @@ const { spawn } = require('child_process')
 const defaultFixturePath = join(__dirname, '../../fixtures/app')
 
 const npmRunner = process.platform === 'win32' ? 'npm.cmd' : 'npm'
-const installArgs = ['install', '--progress=false', '--no-audit', '--omit=optional', '--no-save', '--legacy-peer-deps']
+const installArgs = ['install', '--progress=false', '--no-audit', '--omit=optional', '--no-save']
 const log = (msg, ...args) => console.log(`  [TestApp] ${msg}`, ...args)
 
 class TestApp {

diff --git a/test/node/features/fixtures/cause/Dockerfile b/test/node/features/fixtures/cause/Dockerfile
@@ -8,4 +8,4 @@ RUN npm install
 
 COPY . ./
 
-RUN npm install --no-package-lock --no-save --legacy-peer-deps bugsnag-node*.tgz
+RUN npm install --no-package-lock --no-save bugsnag-node*.tgz
diff --git a/test/node/features/fixtures/connect/Dockerfile b/test/node/features/fixtures/connect/Dockerfile
@@ -8,7 +8,7 @@ RUN npm install
 
 COPY . ./
 
-RUN npm install --no-package-lock --no-save --legacy-peer-deps bugsnag-node*.tgz bugsnag-plugin-express*.tgz
+RUN npm install --no-package-lock --no-save bugsnag-node*.tgz bugsnag-plugin-express*.tgz
 
 ENV NODE_ENV production
 CMD node scenarios/app
diff --git a/test/node/features/fixtures/contextualize/Dockerfile b/test/node/features/fixtures/contextualize/Dockerfile
@@ -8,4 +8,4 @@ RUN npm install
 
 COPY . ./
 
-RUN npm install --no-package-lock --no-save --legacy-peer-deps bugsnag-node*.tgz
+RUN npm install --no-package-lock --no-save bugsnag-node*.tgz
diff --git a/test/node/features/fixtures/express/Dockerfile b/test/node/features/fixtures/express/Dockerfile
@@ -8,7 +8,7 @@ RUN npm install
 
 COPY . ./
 
-RUN npm install --no-package-lock --no-save --legacy-peer-deps bugsnag-node*.tgz bugsnag-plugin-express*.tgz
+RUN npm install --no-package-lock --no-save bugsnag-node*.tgz bugsnag-plugin-express*.tgz
 
 ENV NODE_ENV production
 CMD node scenarios/app
diff --git a/test/node/features/fixtures/handled/Dockerfile b/test/node/features/fixtures/handled/Dockerfile
@@ -8,4 +8,4 @@ RUN npm install
 
 COPY . ./
 
-RUN npm install --no-package-lock --no-save --legacy-peer-deps bugsnag-node*.tgz
+RUN npm install --no-package-lock --no-save bugsnag-node*.tgz
diff --git a/test/node/features/fixtures/koa-1x/Dockerfile b/test/node/features/fixtures/koa-1x/Dockerfile
@@ -8,7 +8,7 @@ RUN npm install
 
 COPY . ./
 
-RUN npm install --no-package-lock --no-save --legacy-peer-deps bugsnag-node*.tgz bugsnag-plugin-koa*.tgz
+RUN npm install --no-package-lock --no-save bugsnag-node*.tgz bugsnag-plugin-koa*.tgz
 
 ENV NODE_ENV production
 CMD node scenarios/app
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,4 +8,4 @@ RUN npm install

		COPY . ./

		RUN npm install --no-package-lock --no-save --legacy-peer-deps bugsnag-node*.tgz
		RUN npm install --no-package-lock --no-save bugsnag-node*.tgz