From 296c1f190b2342a50efd47c820b05621c79795e9 Mon Sep 17 00:00:00 2001
From: Alex Moinet <alex@bugsnag.com>
Date: Mon, 12 Dec 2022 15:23:25 +0000
Subject: [PATCH 1/5] Add oversized payload test to electron

---
 test/electron/features/delivery.feature       | 20 +++++++++++++++++++
 test/electron/fixtures/app/index.html         |  1 +
 test/electron/fixtures/app/main.js            | 19 ++++++++++++++++++
 .../electron/fixtures/app/preloads/default.js |  3 +++
 4 files changed, 43 insertions(+)
 create mode 100644 test/electron/features/delivery.feature

diff --git a/test/electron/features/delivery.feature b/test/electron/features/delivery.feature
new file mode 100644
index 0000000000..a4a2491de6
--- /dev/null
+++ b/test/electron/features/delivery.feature
@@ -0,0 +1,20 @@
+Feature: Delivery of errors
+
+    Scenario: Delivery for an oversized error is not retried
+        Given I launch an app
+        And I set the HTTP status code for the next "POST" request to 400
+        And I click "main-oversized"
+        Then the total requests received by the server matches:
+            | events  | 1        |
+        And the headers of every event request contains:
+            | Bugsnag-API-Key   | 6425093c6530f554a9897d2d7d38e248 |
+            | Content-Type      | application/json                 |
+            | Bugsnag-Integrity | {BODY_SHA1}                      |
+        # Check that resend is not attempted next load (e.g. for when persistence/retry is supported in node)
+        When I close the app
+        And I discard the oldest error
+        And I launch the app
+        Then I should receive no errors
+        Then the total requests received by the server matches:
+            | events   | 0 |
+            | sessions | 0 |
\ No newline at end of file
diff --git a/test/electron/fixtures/app/index.html b/test/electron/fixtures/app/index.html
index 4ca6f03f6a..3813992fcf 100644
--- a/test/electron/fixtures/app/index.html
+++ b/test/electron/fixtures/app/index.html
@@ -13,6 +13,7 @@ <h2>actions</h2>
         <li><a href="#" id="main-process-uncaught-exception" onclick="RunnerAPI.mainProcessUncaughtException()">Uncaught exception in main process</a></li>
         <li><a href="#" id="main-process-unhandled-promise-rejection" onclick="RunnerAPI.mainProcessUnhandledPromiseRejection()">Unhandled promise rejection in main process</a></li>
         <li><a href="#" id="main-notify" onclick="RunnerAPI.mainProcessNotify()">Handled error in main process</a></li>
+        <li><a href="#" id="main-oversized" onclick="RunnerAPI.mainProcessOversized()">Handled error with oversized payload in main process</a></li>
         <li><a href="#" id="child-process-crash" onclick="RunnerAPI.childProcessCrash()">Crash in child process</a></li>
     </ul>
     <ul>
diff --git a/test/electron/fixtures/app/main.js b/test/electron/fixtures/app/main.js
index d3fdaa2ac3..c677dffc48 100644
--- a/test/electron/fixtures/app/main.js
+++ b/test/electron/fixtures/app/main.js
@@ -63,6 +63,25 @@ ipcMain.on('main-process-uncaught-exception', uncaughtException)
 
 ipcMain.on('main-process-notify', notify)
 
+ipcMain.on('main-process-oversized', () => {
+  function repeat(s, n){
+    var a = [];
+    while(a.length < n){
+        a.push(s);
+    }
+    return a.join('');
+  }
+
+  var big = {};
+  var i = 0;
+  while (JSON.stringify(big).length < 2*10e5) {
+    big['entry'+i] = repeat('long repetitive string', 1000);
+    i++;
+  }
+  Bugsnag.leaveBreadcrumb('big thing', big);
+  notify()
+})
+
 ipcMain.on('main-process-crash', crash)
 
 ipcMain.on('delayed-main-process-crash', () => setTimeout(() => crash(), 1000))
diff --git a/test/electron/fixtures/app/preloads/default.js b/test/electron/fixtures/app/preloads/default.js
index 175917c95d..36376c8d19 100644
--- a/test/electron/fixtures/app/preloads/default.js
+++ b/test/electron/fixtures/app/preloads/default.js
@@ -21,6 +21,9 @@ contextBridge.exposeInMainWorld('RunnerAPI', {
   mainProcessNotify: () => {
     ipcRenderer.send('main-process-notify')
   },
+  mainProcessOversized: () => {
+    ipcRenderer.send('main-process-oversized')
+  },
   mainProcessLog: (...args) => {
     ipcRenderer.send('main-process-console-log', ...args)
   },

From 5ee848258ccd1d2df41b43fc83013f9daf5ca925 Mon Sep 17 00:00:00 2001
From: Alex Moinet <alex@bugsnag.com>
Date: Mon, 12 Dec 2022 15:47:49 +0000
Subject: [PATCH 2/5] Use correct electron syntax and implement missing status
 code step

---
 test/electron/features/delivery.feature             |  9 +++------
 test/electron/features/support/server.js            | 13 ++++++++++---
 .../features/support/steps/request-steps.js         |  4 ++++
 3 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/test/electron/features/delivery.feature b/test/electron/features/delivery.feature
index a4a2491de6..c7e05c9197 100644
--- a/test/electron/features/delivery.feature
+++ b/test/electron/features/delivery.feature
@@ -2,7 +2,7 @@ Feature: Delivery of errors
 
     Scenario: Delivery for an oversized error is not retried
         Given I launch an app
-        And I set the HTTP status code for the next "POST" request to 400
+        And I set the next http status code to 400
         And I click "main-oversized"
         Then the total requests received by the server matches:
             | events  | 1        |
@@ -12,9 +12,6 @@ Feature: Delivery of errors
             | Bugsnag-Integrity | {BODY_SHA1}                      |
         # Check that resend is not attempted next load (e.g. for when persistence/retry is supported in node)
         When I close the app
-        And I discard the oldest error
-        And I launch the app
-        Then I should receive no errors
+        And I launch an app
         Then the total requests received by the server matches:
-            | events   | 0 |
-            | sessions | 0 |
\ No newline at end of file
+            | events   | 1 |
\ No newline at end of file
diff --git a/test/electron/features/support/server.js b/test/electron/features/support/server.js
index ae63baabc7..83d33d1bcc 100644
--- a/test/electron/features/support/server.js
+++ b/test/electron/features/support/server.js
@@ -6,6 +6,7 @@ const { promisify } = require('util')
 
 class MockServer {
   constructor () {
+    this.responseStatusCode = 202
     this.eventUploads = []
     this.sessionUploads = []
     this.minidumpUploads = []
@@ -38,19 +39,25 @@ class MockServer {
     this.awaitingUploads = []
   }
 
+  _statusCode () {
+    statusCode = this.responseStatusCode
+    this.responseStatusCode = 202
+    return statusCode
+  }
+
   async uploadMinidump (req, res) {
     const form = formidable()
     form.parse(req, (_err, fields, files) => {
       const boundary = this.readBoundary(req.headers['content-type'])
       this.minidumpUploads.push({ headers: req.headers, boundary, fields, files })
-      res.writeHead(202)
+      res.writeHead(this._statusCode())
       res.end()
       this._notifyUploads()
     })
   }
 
   async sendEvent (req, res) {
-    res.writeHead(202)
+    res.writeHead(this._statusCode())
     let body = ''
     req.on('data', (chunk) => { body += chunk })
     req.on('end', () => {
@@ -61,7 +68,7 @@ class MockServer {
   }
 
   async sendSession (req, res) {
-    res.writeHead(202)
+    res.writeHead(this._statusCode())
     let body = ''
     req.on('data', (chunk) => { body += chunk })
     req.on('end', () => {
diff --git a/test/electron/features/support/steps/request-steps.js b/test/electron/features/support/steps/request-steps.js
index 2a5d20c019..ec8322af7f 100644
--- a/test/electron/features/support/steps/request-steps.js
+++ b/test/electron/features/support/steps/request-steps.js
@@ -26,6 +26,10 @@ const featureFlagsTableToExpected = table => {
   })
 }
 
+Given('I set the next http status code to {int}', (responseCode) => {
+  global.server.responseStatusCode = responseCode
+})
+
 Given('I launch an app', launchConfig, async () => {
   return global.automator.start()
 })

From cac77e48131586a215137ae22ccdd63673cd8178 Mon Sep 17 00:00:00 2001
From: Alex Moinet <alex@bugsnag.com>
Date: Mon, 12 Dec 2022 15:56:15 +0000
Subject: [PATCH 3/5] Use correct JS syntax

---
 test/electron/features/support/server.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/electron/features/support/server.js b/test/electron/features/support/server.js
index 83d33d1bcc..603bff232e 100644
--- a/test/electron/features/support/server.js
+++ b/test/electron/features/support/server.js
@@ -40,7 +40,7 @@ class MockServer {
   }
 
   _statusCode () {
-    statusCode = this.responseStatusCode
+    var statusCode = this.responseStatusCode
     this.responseStatusCode = 202
     return statusCode
   }

From e80605636ece50c2bdcd15febe0a2bd7f9c2be34 Mon Sep 17 00:00:00 2001
From: Alex Moinet <alex@bugsnag.com>
Date: Thu, 15 Dec 2022 15:42:33 +0000
Subject: [PATCH 4/5] Fix linting errors

---
 test/electron/fixtures/app/main.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/test/electron/fixtures/app/main.js b/test/electron/fixtures/app/main.js
index c677dffc48..859e1228de 100644
--- a/test/electron/fixtures/app/main.js
+++ b/test/electron/fixtures/app/main.js
@@ -64,21 +64,21 @@ ipcMain.on('main-process-uncaught-exception', uncaughtException)
 ipcMain.on('main-process-notify', notify)
 
 ipcMain.on('main-process-oversized', () => {
-  function repeat(s, n){
-    var a = [];
-    while(a.length < n){
-        a.push(s);
+  function repeat (s, n) {
+    var a = []
+    while (a.length < n) {
+      a.push(s)
     }
-    return a.join('');
+    return a.join('')
   }
 
-  var big = {};
-  var i = 0;
-  while (JSON.stringify(big).length < 2*10e5) {
-    big['entry'+i] = repeat('long repetitive string', 1000);
-    i++;
+  var big = {}
+  var i = 0
+  while (JSON.stringify(big).length < 2 * 10e5) {
+    big['entry' + i] = repeat('long repetitive string', 1000)
+    i++
   }
-  Bugsnag.leaveBreadcrumb('big thing', big);
+  Bugsnag.leaveBreadcrumb('big thing', big)
   notify()
 })
 

From 7f12a56cc71a35c86f3414a02a56537ea6e3adca Mon Sep 17 00:00:00 2001
From: Alex Moinet <alex@bugsnag.com>
Date: Mon, 19 Dec 2022 14:48:29 +0000
Subject: [PATCH 5/5] Update test/electron/features/delivery.feature

Co-authored-by: djskinner <dan@bugsnag.com>
---
 test/electron/features/delivery.feature | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/electron/features/delivery.feature b/test/electron/features/delivery.feature
index c7e05c9197..8697c828ee 100644
--- a/test/electron/features/delivery.feature
+++ b/test/electron/features/delivery.feature
@@ -10,7 +10,7 @@ Feature: Delivery of errors
             | Bugsnag-API-Key   | 6425093c6530f554a9897d2d7d38e248 |
             | Content-Type      | application/json                 |
             | Bugsnag-Integrity | {BODY_SHA1}                      |
-        # Check that resend is not attempted next load (e.g. for when persistence/retry is supported in node)
+        # Check that resend is not attempted next load
         When I close the app
         And I launch an app
         Then the total requests received by the server matches: