Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented and incorrect payload size limit #1786

Open
2 tasks
bbotto-pdga opened this issue Jul 8, 2022 · 3 comments
Open
2 tasks

Undocumented and incorrect payload size limit #1786

bbotto-pdga opened this issue Jul 8, 2022 · 3 comments
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature

Comments

@bbotto-pdga
Copy link

bbotto-pdga commented Jul 8, 2022

Describe the bug

We've noticed that we're missing Bugsnag reports because our stack traces exceed 1E6 bytes. This doesn't appear to be documented, and the only mention of a payload limit is in this issue, which is closed: #245

When our stack traces exceed 1E6 bytes, we're seeing this error trigger: https://github.com/bugsnag/bugsnag-js/blob/v7.17.2/packages/core/lib/json-payload.js#L18 There is no indication that an error occurred in Bugsnag.

10E5 is 47KB short of a megabyte. 47K is quite a bit of data when the limit is so small.

Anyway, is there anything we can do here so that we receive our production error reports? We can't really control the size of the stack traces.

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Environment

  • Bugsnag version: 7.16.2
  • Browser framework version (if any): Vue3
  • Browser version (e.g. chrome, safari): Mainly Safari (stack traces for the same error in Chrome and FireFox are much smaller)
  • Device (e.g. iphonex):

Example Repo

  • Create a minimal repository that can reproduce the issue
  • Link to it here:

Example code snippet

# (Insert code sample to reproduce the problem)
Error messages:

@gareththackeray
Copy link
Contributor

Hi @bbotto-pdga sorry you've run into this problem. Would you be able to let us see a sample oversize event? Are you confident that it is the stack trace that is taking up the space. Could either paste one here or else email it to [email protected]?

@luke-belton luke-belton added the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jul 11, 2022
@bbotto-pdga
Copy link
Author

Hey @gareththackeray,

Sorry to misreport the issue. I assumed incorrectly that the stack trace was the culprit, but it turned out to be breadcrumbs. The large breadcrumbs came from an internal Vue console.warning after a crash, and the console warnings included the internal state of our components over and over again, which resulted in a large payload.

In the code I linked in the original issue, the metadata is removed when the payload is too large. Can the same be done for the breadcrumbs? In this case, we were missing crash reports due to these large breadcrumbs. It would be awesome if Bugsnag would let us know if our application crashes in all cases, even if that means dropping the breadcrumbs.

For the time being, we've disabled log breadcrumbs.

Thanks!

@luke-belton luke-belton removed the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jul 13, 2022
@gareththackeray
Copy link
Contributor

Glad you found the issue. We have an item on our roadmap to drop breadcrumbs as required.

@luke-belton luke-belton added feature request Request for a new feature backlog We hope to fix this feature/bug in the future labels Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants