Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startSession should no longer clone the client #2003

Merged
merged 2 commits into from
Sep 1, 2023
Merged

startSession should no longer clone the client #2003

merged 2 commits into from
Sep 1, 2023

Conversation

djskinner
Copy link
Contributor

@djskinner djskinner commented Aug 11, 2023 •
edited
Loading

Goal

Update startSession so that it starts a session in the current client, rather than cloning the client. The method should behave like the other client methods, so that calling Bugsnag.notify or req.bugsnag.notify afterwards would be in the new session.

Testing

@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 44.38 kB 13.53 kB
After 44.38 kB 13.53 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against cdde0fd

@djskinner djskinner requested a review from tomlongridge August 14, 2023 13:53
@djskinner djskinner marked this pull request as ready for review August 14, 2023 13:53
@djskinner djskinner merged commit af62b01 into integration/v8 Sep 1, 2023
9 checks passed
@djskinner djskinner deleted the plat-10750 branch September 1, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoehaines imjoehaines imjoehaines approved these changes

@tomlongridge tomlongridge Awaiting requested review from tomlongridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djskinner @imjoehaines