Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert @bugsnag/plugin-browser-device #2227

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Convert @bugsnag/plugin-browser-device #2227

merged 5 commits into from
Oct 21, 2024

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Oct 16, 2024 •
edited
Loading

Goal

Convert package to TypeScript and ES Modules

Changeset

  • Refactor @bugsnag/plugin-browser-device package
  • Modularise plugin functionality
  • Simplify rollup bundle scripts

Testing

Covered by CI run

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.80 kB 13.80 kB
After 45.83 kB 13.81 kB
± ⚠️ +25 bytes ⚠️ +8 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 069bdb0

@gingerbenw gingerbenw force-pushed the PLAT-12161/plugin-browser-device branch from 3e15f09 to 8224182 Compare October 16, 2024 14:08
Base automatically changed from PLAT-12159/plugin-app-duration to integration/typescript October 21, 2024 11:34
@gingerbenw gingerbenw marked this pull request as ready for review October 21, 2024 13:13
@gingerbenw gingerbenw merged commit 6cb0178 into integration/typescript Oct 21, 2024
56 checks passed
@gingerbenw gingerbenw deleted the PLAT-12161/plugin-browser-device branch October 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

@lemnik lemnik Awaiting requested review from lemnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @djskinner