Convert @bugsnag/plugin-browser-request to TypeScript #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
integration/typescript
branch
from
0b18a5e to
25ca84e
Compare
gingerbenw
force-pushed
the
PLAT-12162-plugin-browser-request
branch
from
97730a0 to
3c3d2ae
Compare
gingerbenw
force-pushed
the
PLAT-12162-plugin-browser-request
branch
from
87cb38e to
6df580b
Compare
gingerbenw
reviewed
Oct 24, 2024
Comment on lines
78
to
81
| // @ts-expect-error IE8 onunhandledrejection does not match the signature of the modern listener | ||
| win.onunhandledrejection = (reason, promise) => { | ||
| // @ts-expect-error detail does not exist on type PromiseRejectionEvent | ||
| listener({ detail: { reason, promise } }) | ||
| listener({ detail: { reason, promise } } as unknown as PromiseRejectionEvent) | ||
| } |
There was a problem hiding this comment.
@tomlongridge have we officially dropped support for IE8 now? this block can go if so 🔥
gingerbenw
approved these changes
Oct 28, 2024
gingerbenw
added a commit
that referenced
this pull request
Nov 12, 2024
* refactor: ♻️ convert plugin-window-onerror to typescript * update rollup configuration * Convert plugin-browser-request to TypeScript * changed tsconfig * fix: 🩹 update main entry from ts to js * fix: 🩹 add missing external dependencies to rollup config * chore: 🏷️ update types and remove ts-expect-error comments * remove unnecessary rollup config * chore: 🏷️ fix types * chore: 🔥 remove IE8 workaround code * fix: 🩹 fix RN init command --------- Co-authored-by: Ben Wilson <[email protected]>
gingerbenw
added a commit
that referenced
this pull request
Nov 25, 2024
* refactor: ♻️ convert plugin-window-onerror to typescript * update rollup configuration * Convert plugin-browser-request to TypeScript * changed tsconfig * fix: 🩹 update main entry from ts to js * fix: 🩹 add missing external dependencies to rollup config * chore: 🏷️ update types and remove ts-expect-error comments * remove unnecessary rollup config * chore: 🏷️ fix types * chore: 🔥 remove IE8 workaround code * fix: 🩹 fix RN init command --------- Co-authored-by: Ben Wilson <[email protected]>
gingerbenw
added a commit
that referenced
this pull request
Dec 5, 2024
* refactor: ♻️ convert plugin-window-onerror to typescript * update rollup configuration * Convert plugin-browser-request to TypeScript * changed tsconfig * fix: 🩹 update main entry from ts to js * fix: 🩹 add missing external dependencies to rollup config * chore: 🏷️ update types and remove ts-expect-error comments * remove unnecessary rollup config * chore: 🏷️ fix types * chore: 🔥 remove IE8 workaround code * fix: 🩹 fix RN init command --------- Co-authored-by: Ben Wilson <[email protected]>
gingerbenw
added a commit
that referenced
this pull request
Dec 5, 2024
* refactor: ♻️ convert plugin-window-onerror to typescript * update rollup configuration * Convert plugin-browser-request to TypeScript * changed tsconfig * fix: 🩹 update main entry from ts to js * fix: 🩹 add missing external dependencies to rollup config * chore: 🏷️ update types and remove ts-expect-error comments * remove unnecessary rollup config * chore: 🏷️ fix types * chore: 🔥 remove IE8 workaround code * fix: 🩹 fix RN init command --------- Co-authored-by: Ben Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert package to TypeScript and ES Modules
Design
Changeset
-Refactor @bugsnag/plugin-browser-request package
Testing