Hotfix: promise rejection configuration #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
changed the title
gingerbenw
commented
Oct 24, 2024
Comment on lines
40
to
51
| Scenario: reporting unhandled promise rejections as handled | ||
| And I run the service "unhandled" with the command "node scenarios/unhandled-promise-rejection-as-handled" | ||
| And I wait to receive an error | ||
| Then the error is valid for the error reporting API version "4" for the "Bugsnag Node" notifier | ||
| And the event "unhandled" is true | ||
| And the event "unhandled" is false | ||
| And the event "severity" equals "error" | ||
| And the event "severityReason.type" equals "unhandledPromiseRejection" | ||
| And the exception "errorClass" equals "Error" | ||
| And the exception "message" equals "not handled" | ||
| And the exception "type" equals "nodejs" | ||
| And the "file" of stack frame 0 equals "scenarios/unhandled-promise-rejection.js" | ||
| And the "file" of stack frame 0 equals "scenarios/unhandled-promise-rejection-as-handled.js" | ||
| And the "lineNumber" of stack frame 0 equals 10 |
There was a problem hiding this comment.
This was previously a duplicate of the scenario above, hence rewriting and not adding a new one
|
is there a reason we haven't added a scenario for React Native? |
|
@yousif-bugsnag just that we've covered it with unit tests - but it wouldn't hurt to add one I suppose! |
yousif-bugsnag
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensure
reportUnhandledPromiseRejectionsAsHandledconfig options is correctly handled and tested in react-nativeTesting
Add unit tests for react-native to ensure configuration (and typescript definitions) handle new config value