Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoSuchMethodError in ReactNative tests #2254

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix NoSuchMethodError in ReactNative tests #2254

merged 1 commit into from
Nov 15, 2024

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Nov 15, 2024

Goal

Fix NoSuchMethodError in ReactNative tests

Changeset

Replaced api with compileOnly for bugsnag-android dependency in the scenario loader to avoid accidentally upgrading the version of bugsnag-android included in the test fixture beyond the expected version.

Testing

Existing tests should pass again.

@lemnik lemnik requested review from Cawllec and gingerbenw November 15, 2024 11:19
@github-actions GitHub Actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against ae25890

@lemnik lemnik merged commit 367ae58 into next Nov 15, 2024
59 checks passed
@lemnik lemnik deleted the PLAT-13077/fix-rn-fixture branch November 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerbenw gingerbenw gingerbenw approved these changes

@Cawllec Cawllec Awaiting requested review from Cawllec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemnik @gingerbenw