Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor delivery-x-domain-request #2255

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Refactor delivery-x-domain-request #2255

merged 5 commits into from
Nov 22, 2024

Conversation

gingerbenw
Copy link
Member

Goal

Convert source code to TypeScript and export both es modules and common js modules

Testing

Covered by existing test suite

@gingerbenw gingerbenw changed the title Refactor delivery-x-domain-request to TypeScript and ES Modules Refactor delivery-x-domain-request Nov 20, 2024
@gingerbenw gingerbenw marked this pull request as ready for review November 20, 2024 12:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.99 kB 13.81 kB
After 46.13 kB 13.85 kB
± ⚠️ +140 bytes ⚠️ +35 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against bf033a0

@gingerbenw gingerbenw merged commit 46873ef into integration/typescript Nov 22, 2024
56 checks passed
@gingerbenw gingerbenw deleted the PLAT-13092/delivery-x-domain-request branch November 22, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnastasiiaSvietlova AnastasiiaSvietlova AnastasiiaSvietlova approved these changes

@lemnik lemnik Awaiting requested review from lemnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @AnastasiiaSvietlova