Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor @bugsnag/plugin-strip-query-string #2266

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Refactor @bugsnag/plugin-strip-query-string #2266

merged 1 commit into from
Nov 29, 2024

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Nov 27, 2024 •
edited
Loading

Goal

Refactor @bugsnag/plugin-strip-query-string to TypeScript source code exporting ES Modules

Testing

Covered by existing CI

@github-actions GitHub Actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 46.14 kB 13.86 kB
After 46.14 kB 13.86 kB
± -5 bytes -1 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against b3677d9

@gingerbenw gingerbenw changed the title refactor: ♻️ refactor plugin-strip-query-string to TypeScript … Refactor plugin-strip-query-string Nov 27, 2024
@gingerbenw gingerbenw changed the title Refactor plugin-strip-query-string Refactor @bugsnag/plugin-strip-query-string Nov 29, 2024
@gingerbenw gingerbenw marked this pull request as ready for review November 29, 2024 17:11
@gingerbenw
Copy link
Member Author

iOS 10 failure unrelated to this change and being resolved in #2269

@gingerbenw gingerbenw merged commit 9a4591e into integration/typescript Nov 29, 2024
54 of 56 checks passed
@gingerbenw gingerbenw deleted the PLAT-13091/plugin-strip-query-string branch November 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnastasiiaSvietlova AnastasiiaSvietlova AnastasiiaSvietlova approved these changes

@yousif-bugsnag yousif-bugsnag Awaiting requested review from yousif-bugsnag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @AnastasiiaSvietlova