Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable detailed cache stats #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable detailed cache stats #26

wants to merge 1 commit into from

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented Jul 22, 2022 •
edited
Loading

@bduffany bduffany changed the title Enable detailed cache stats in helm chart Enable detailed cache stats Jul 22, 2022
@sluongng sluongng requested a review from siggisim March 9, 2023 13:31
sluongng
sluongng reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm but might need to come with a chart version bump in Chart.yaml files

Question: do we want to enable this feature by default? I.e. should we remove this config all together and simplify our code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sluongng sluongng sluongng left review comments

@siggisim siggisim Awaiting requested review from siggisim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bduffany @sluongng