Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair deletion of last field of a Filter.List #19

Open
simon-wacker opened this issue Nov 3, 2021 · 0 comments
Open

Repair deletion of last field of a Filter.List #19

simon-wacker opened this issue Nov 3, 2021 · 0 comments
Labels
bug Something isn't working frontend ISE Fraunhofer Institute for Solar Energy Systems ISE

Comments

@simon-wacker
Copy link
Contributor

simon-wacker commented Nov 3, 2021

After adding a field to an empty Form.List, hitting Filter, removing that very field, and hitting Filter again, the value of that last field is passed as variable to the GraphQL query requested by *Query.refetch, although it is not given as parameter to *Query.refetch. This is only a problem when after removing the field the Form.List is empty, that is, there is no other proposition present. The most relevant code snippet is https://github.com/ise621/database/blob/e23f0107668b1da5d2a304d1135c79d4cde6d2e3/frontend/pages/data/optical.tsx#L264-L270

This happens for example on the page /data/optical with Nearnormal hemispherical solar reflectance propositions. To see the actual GrapQL query requested from the server use the Network tab of the Web Developer Tools.

Maybe the following documentations can shed some light on the issue https://www.apollographql.com/docs/react/api/core/ObservableQuery/#ObservableQuery.refetch and https://www.apollographql.com/docs/react/data/refetching/

@simon-wacker simon-wacker added bug Something isn't working frontend labels Nov 3, 2021
@christoph-maurer christoph-maurer moved this to 📋 Backlog in EQWIN-P Jan 17, 2023
@simon-wacker simon-wacker added the ISE Fraunhofer Institute for Solar Energy Systems ISE label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend ISE Fraunhofer Institute for Solar Energy Systems ISE
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant