Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf content type instead of JSON for k8s API calls #400

Open
bpoland opened this issue Oct 17, 2024 · 1 comment
Open

Use protobuf content type instead of JSON for k8s API calls #400

bpoland opened this issue Oct 17, 2024 · 1 comment

Comments

@bpoland
Copy link

bpoland commented Oct 17, 2024

The Kubernetes docs say this about content type for API requests:

Although JSON is the default, clients may request the more efficient binary Protobuf representation for better performance at scale.

Based on a quick search here I don't think agent-stack-k8s is doing that (and it is not enabled by default in the k8s go client) -- would you consider either defaulting to protobuf or allowing it to be switched on with some configuration? It appears the implementation would be relatively simple e.g. https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2138/files

Thanks!

@dabarrell
Copy link

Hey @bpoland! Looks like it could be a possible improvement! It's not going to be something on our immediate radar, but we'd be happy to review a PR if you put one together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants