Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling on Waiting has unexpected behavior #199

Open
baderbuddy opened this issue Nov 27, 2024 · 1 comment
Open

Scaling on Waiting has unexpected behavior #199

baderbuddy opened this issue Nov 27, 2024 · 1 comment

Comments

@baderbuddy
Copy link

Because every job behind a block is considered waiting, if you turn on scaling based on waiting it could cause a lot of unexpected scaling. In our organization we do a lot of block steps for optional things like rollbacks, that most of hte tiem are never executed, so we have plenty of jobs that are stuck in a waiting stage that never get cleaned up.

Having a little more logic in there to exclude older blocked steps, or jobs behind a block would make this option much more useful.

@DrJosh9000
Copy link
Contributor

Thanks @baderbuddy, that's a good point.

Currently the metrics endpoint only exposes a single "waiting" metric which includes all kinds of waiting jobs. But I think that even if we did break the metric down into different categories (such as behind a block vs not), there might not be a common rule that we could apply to all kinds of pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants