Master => main change broke all clients #386
Comments
|
@kevinburke thanks for the report. Buildkite has been growing quite quickly and I don't think anyone on the team responsible for emojis (my team!) realised that the bk cli was using this repo in such a way. As a really quick and dirty "fix" I've pushed a master branch to GitHub, based on the current main branch. Obviously that won't update though, so we'll have a chat internally about a long term fix. |
yob
added a commit
to buildkite/cli
that referenced
this issue
Jun 26, 2022
In August 2021 we renamed the development branch in the emojis repo from master to main. That was relatively smooth from an emojis development perspective, but we didn't realise the cli had master hard coded. As a quick 'fix' I've re-pushed a master branch to the emojis repo, based on current main. It won't stay up to date though, so this changes the cli to check the main branch instead. See also: buildkite/emojis#386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The clients work by retrieving emojis on demand from Github and storing them in a local cache. Clients are (still, today) hard coded to retrieve emojis from the "master" branch, which was moved to the "main" branch. As a result Github is serving 404's for all emoji URL's. This probably explains #385.
See e.g. https://github.com/buildkite/cli/blob/main/local/emoji.go#L22-L26.
The text was updated successfully, but these errors were encountered: