Change agent to mac-os latest #609
Conversation
KovalevAndrey
force-pushed
the
2.x-change-agent-to-mac-os
branch
from
8a96de2 to
dc86b74
Compare
.github/workflows/build.yml
Outdated
| @@ -14,7 +14,7 @@ env: | |||
| jobs: | |||
| build: | |||
| name: Build | |||
| runs-on: ubuntu-latest | |||
| runs-on: macOS-latest | |||
There was a problem hiding this comment.
There is a limit on mac-os agents per repo, makes sense to check of we can merge with instrumentation tests (both variants). Definitely makes sense to merge with Publication verification, both builds all libs, the second one just does simple job on packing and posting to local folder. It will reduce amount of unique caches. But fine to do as a separate PR.
There was a problem hiding this comment.
I would suggest instead separately into even more granular jobs instead.
i.e. a job that builds:
- Android (ubuntu)
- Web (ubuntu)
- Desktop (ubuntu)
- iOS (mac)
or at the very least split iOS build into its own job instead. This will reduce the amount of agents used overall by parallel PRs as the iOS build job would finish a lot faster.
There was a problem hiding this comment.
I would suggest instead separately into even more granular jobs instead.
It is such a pain to set up and support it 😭 either specifying manually all platform related tasks, or relying on filtering plugins (trust me, but this particular approach does not work anymore because of Gradle updates).
If you are ready to do it, will support you!
.github/workflows/build.yml
Outdated
| @@ -162,7 +162,7 @@ jobs: | |||
|
|
|||
| check-documentation: | |||
| name: Check documentation | |||
| runs-on: ubuntu-latest | |||
| runs-on: macOS-latest | |||
There was a problem hiding this comment.
Documentation builds only JS, it is fine to stay on ubuntu.
.github/workflows/documentation.yml
Outdated
| @@ -9,7 +9,7 @@ on: | |||
| jobs: | |||
| deploy: | |||
| name: Deploy | |||
| runs-on: ubuntu-latest | |||
| runs-on: macOS-latest | |||
There was a problem hiding this comment.
Documentation builds only JS, it is fine to stay on ubuntu.
Also this one does not have Generate distributions step from check.
gradle/libs.versions.toml
Outdated
| coroutines = "1.6.4" | ||
| dependencyAnalysis = "1.13.1" | ||
| detekt = "1.21.0" | ||
| junit5 = "5.8.2" | ||
| jvmTarget = "11" | ||
| kotlin = "1.8.10" | ||
| ksp = "1.8.0-1.0.8" | ||
| kotlin = "1.9.10" |
There was a problem hiding this comment.
Too early, we might not be able to use this version internally.
There was a problem hiding this comment.
I know, was testing a fix for an issue https://youtrack.jetbrains.com/issue/KT-60230/Native-unknown-options-iossimulatorversionmin-sdkversion-with-Xcode-15-beta-3 which was fixed in 1.9.10
There was a problem hiding this comment.
You can set xcode version to the one that is currently supported (idk which one on 1.8, just try)
https://github.com/badoo/Reaktive/blob/master/.github/workflows/build.yml#L27
KovalevAndrey
force-pushed
the
2.x-change-agent-to-mac-os
branch
from
35bc01c to
090a244
Compare
KovalevAndrey
force-pushed
the
2.x-change-agent-to-mac-os
branch
from
090a244 to
7b9ce51
Compare
Description
Release action can not publish iOS targets since the agent is not a macOS. We need to change agents to support that.
Check list
CHANGELOG.mdif required.