Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom headers don't override the default ones #141

Open
2 tasks done
panovitch opened this issue Jul 14, 2021 · 1 comment · May be fixed by #142
Open
2 tasks done

Custom headers don't override the default ones #141

panovitch opened this issue Jul 14, 2021 · 1 comment · May be fixed by #142

Comments

@panovitch
Copy link

panovitch commented Jul 14, 2021 •
edited
Loading

Steps to reproduce:

  1. Pass a custom header to override the default one, e.g. client-request-id:
Payment.create(
    new Amount("123", "EUR"),
    new Pointer("IBAN", "mockiban"),
    "description",
    123,
    null,
    null,
    false,
    Map(
      BunqHeader.CLIENT_REQUEST_ID.toString -> "123"
    ).toJava)

What should happen:

  1. The specified request header gets passed to the server, and the server recognises the Client Request ID.

What happens:

  1. The server doesnt recognise the passed client request ID, and doesnt deduplicate the requests. Upon further investigation, I found out that the new header value gets appended to the header key, instead of replacing it.

Traceback

SDK version and environment

  • Tested on 1.14.1
  • Sandbox
  • Production

Response id

  • Response id:

Extra info:
panovitch pushed a commit to panovitch/sdk_java that referenced this issue Jul 14, 2021
Custom headers now override the default ones (bunq#141)
ff58edc
@panovitch panovitch linked a pull request Jul 14, 2021 that will close this issue
Open
1 task
meslubi2021 added a commit to Unity-Banking-and-financial-institution/sdk_java that referenced this issue Jan 4, 2025
@meslubi2021
Merge pull request #6 from panovitch/custom-header-override-defaults
1659931 
Custom headers now override the default ones (bunq#141)
@two-trick-pony-NL
Copy link

👋 Hey @panovitch

I work at bunq and am currently reviewing the bunq API docs, open issues and SDK’s and came across your issue. I know it’s been open for a while, and I’d love to understand how it’s impacting you. Beyond the obvious -fixing this issue-, what else could we do to improve your experience with our API?

If you want to share your thoughts on how we can improve on our public API:

📅 I'd love to schedule a 15 minute interview to understand your needs through: Calendly
💬 Or if you don't have time for a call, you can give us some general feedback through this form

Your feedback will go straight to our product team! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom headers passed now override the default ones panovitch/sdk_java
2 participants
@panovitch @two-trick-pony-NL