From 7de3431106d1ae2d2ec35556586884dee7c27455 Mon Sep 17 00:00:00 2001
From: butterunderflow <azhong.934@gmail.com>
Date: Sun, 9 Jun 2024 02:28:21 +0800
Subject: [PATCH] refactor: more strict environment absorb

---
 lib/typing/check.ml | 19 ++++++++++---------
 lib/typing/env.ml   |  8 ++++----
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/lib/typing/check.ml b/lib/typing/check.ml
index a21f242..7d6de2e 100644
--- a/lib/typing/check.ml
+++ b/lib/typing/check.ml
@@ -100,7 +100,8 @@ let env_id = ref 0
 let enter_env env =
   env_id := 1 + !env_id;
   Env.record_history !env_id env;
-  { (Env.init_scope ()) with curr = !env_id } :: env
+  let new_scope = { (Env.init_scope ()) with curr = !env_id } in
+  new_scope :: env
 
 let env_newid env =
   env_id := 1 + !env_id;
@@ -118,9 +119,11 @@ let pool_make_tv n =
   | Some tpv -> tpv
   | None -> make_tv ()
 
-(* record top history of env1 to env0 *)
-let absorb_top_history (env0 : Env.t) (env1 : Env.t) =
-  Env.record_all_history (Env.get_top_history env0) env1
+(* record top history of env0 to env1 *)
+let absorb_history (env0 : Env.t) (env1 : Env.t) =
+  let s = Env.prune env0 env1 in
+  Env.record_all_history !(s.history) env1;
+  s
 
 type norm_ctx =
   | Type
@@ -442,9 +445,8 @@ and tc_mod (me : T.mod_expr) (env : Env.t) : mod_expr =
   | T.MEName name -> MEName (name, Env.get_module_def name env)
   | T.MEStruct body ->
       let body_typed, env' = tc_tops body (enter_env env) in
-      let env_diff = Env.get_top_scope env' in
-      absorb_top_history env' env;
-      let mt = make_scope_mt env_diff in
+      let scope = absorb_history env' env in
+      let mt = make_scope_mt scope in
       MEStruct (body_typed, mt)
   | T.MEFunctor ((name, emt0), me1) ->
       let mt0 = normalize_mt emt0 env in
@@ -707,8 +709,7 @@ and normalize_mt (me : T.emod_ty) env : I.mod_ty =
       | I.MTFun (_mt0, _mt1) -> failwith "try get field from functor")
   | T.MTSig comps ->
       let env' = normalize_msig comps (enter_env env) in
-      let scope : Env.scope = Env.get_top_scope env' in
-      absorb_top_history env' env;
+      let scope = absorb_history env' env in
       make_scope_mt scope
   | T.MTFunctor (m0, emt0, m1) ->
       let mt0 = normalize_mt emt0 env in
diff --git a/lib/typing/env.ml b/lib/typing/env.ml
index 9622516..693ede9 100644
--- a/lib/typing/env.ml
+++ b/lib/typing/env.ml
@@ -42,10 +42,10 @@ let get_curr (env : t) =
   | [] -> failwith "neverreach"
   | s :: _ -> s.curr
 
-let get_top_scope env =
-  match env with
-  | [] -> failwith "neverreach"
-  | s :: _ -> s
+let prune env0 env1 =
+  match env0 with
+  | s :: env0' when env0' == env1 -> s
+  | _ -> failwith "neverreach"
 
 let get_top_history (env : t) =
   match env with