Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of V vector may be incorrect. #15

Open
andywinhold opened this issue Nov 7, 2016 · 1 comment
Open

Calculation of V vector may be incorrect. #15

andywinhold opened this issue Nov 7, 2016 · 1 comment

Comments

@andywinhold
Copy link

Hi Bahvin,
First thank you so much for writing these procedures! Austin passed your work on to me when he left so I've been getting acquainted with it.
I'm reading through the planetary paper you mention and I think there may be a small error in calculating the V vector in get_cahvor.py.

According to the planetary applications paper:

V = vs * Hn + vc * A

Where line 110 of get_cahvor.py currently shows:

V = vs * Vn + vc * A

I've searched the paper to make sure I have this correctly, so let me know if I'm missing anything.

Best,

Andy

@bvnayak
Copy link
Owner

bvnayak commented Nov 10, 2016

Hi Andy, Thanks for reviewing it. Highly appreciate it !
I will check my code this weekend and make a new commit if any changes. :)

Best,
Bhavin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants