Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of redis connection #6

Open
wush978 opened this issue Jun 29, 2013 · 1 comment
Open

Management of redis connection #6

wush978 opened this issue Jun 29, 2013 · 1 comment

Comments

@wush978
Copy link

wush978 commented Jun 29, 2013

Hi,

I notice that after entering redisWorker and registerDoRedis, there is a redisConnect. However, before there is a redisClose before leaving redisWorker, but no redisClose before redisConnect.

Since rredis manages connection globally, I suggest to open an API to control whether managing the connection by redisWorker and redisDoRedis or not.

That is to say, if these function call redisConnect at the beginning, then it should call redisClose before leaving. Also, the user should have an option to control whether the redisConnect is called or not.

@bwlewis
Copy link
Owner

bwlewis commented Jul 1, 2014

I'm not sure that it matters. It's safe to call redisConnect multiple times. It sems like this change would just introduce an unneccesary complciation? Am I misinterpreting your idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants