Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept network details, such as whether to use the testnet at startup #13

Open
thedavidmeister opened this issue Oct 18, 2017 · 2 comments

Comments

@thedavidmeister
Copy link

testnetify.sh seems rather fragile to me, is it really OK to rewrite files that npm manages in a way that it is not aware of?

e.g. what stops the modifications getting blown away the next time npm updates the byteballcore dependency?

is there any way that network details could be passed through at startup?

@tonyofbyteball
Copy link
Member

tonyofbyteball commented Oct 26, 2017

e.g. what stops the modifications getting blown away the next time npm updates the byteballcore dependency?

This is what happens. I have to testnetify again after doing npm update on my testnet nodes. I risk to forget to do it, but it makes no damage other than the node staying offline.

Suggestions are welcome. I feel like conf.json is not the right place to define the network because conf defines the config of the node on the given network while testnet/livenet is about the network -- different levels of the hierarchy.

@tarmo888
Copy link
Member

Running this cp .env.testnet .env will now switch to testnet
6662f61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants