Missing shapes in generated code using wasm-tools v1.226.0

[alexcasalboni]

Everything worked well until a couple of days ago (with [email protected]).

With the latest wasm-tools, our generated code is missing some shapes.

Failing GitHub Action here: https://github.com/edgee-cloud/example-go-component/actions/runs/13455120736/job/37597335001?pr=7

How to reproduce:

# wit/deps.toml
edgee = "https://github.com/edgee-cloud/edgee-wit/archive/refs/tags/v0.5.0.tar.gz"
cli = "https://github.com/WebAssembly/wasi-cli/archive/refs/tags/v0.2.0.tar.gz"

// wit/world.wit
package edgee:native;

world data-collection {
  include wasi:cli/imports@0.2.0;
  export edgee:components/data-collection;
}

Generate with:

go run go.bytecodealliance.org/cmd/wit-bindgen-go generate -o internal/ ./wit

Check the file internal/edgee/components/data-collection/abi.go - there should be a type called EdgeeRequestShape but it's not there.

[alexcasalboni]

FYI @alexcrichton @yoshuawuyts @cpetig

[alexcrichton]

While I can't say for certain this is likely related to bytecodealliance/wasm-tools#2050 which changed the JSON output structure and may not be supported here yet.

[alexcasalboni]

Thanks!

That sounds odd because the generation would fail entirely or report some kind or error, while it succeeds and only some of the types/shapes are missing.

Also, I think that ideally this repository could set and maintain its own wasm-tools dependency/version, instead of relying on what is installed on the system (since there could be breaking changes like this one).

Anyways, any pointer to where the issue might be in this repository? I’d love to contribute with a fix.

[brooksmtownsend]

I'm hitting this as well, mostly as an artifact that my exported functions no longer generate result types.

For example, with my WIT:

package example:bug;

interface foo {
  record request {
    headers: list<tuple<string, list<string>>>,
  }

  record response {
      headers: list<tuple<string, list<string>>>,
  }

  funky: func(request: request) -> response;
}

world bar {
  export foo;
}

Then generated with wit-bindgen-go generate --world bar --out gen ./wit, when I have wasm-tools 1.223.1 installed, the output is:

// Code generated by wit-bindgen-go. DO NOT EDIT.

package foo

// Exports represents the caller-defined exports from "example:bug/foo".
var Exports struct {
	// Funky represents the caller-defined, exported function "funky".
	//
	//	funky: func(request: request) -> response
	Funky func(request Request) (result Response)
}

and with wasm-tools 1.226.0:

// Code generated by wit-bindgen-go. DO NOT EDIT.

package foo

// Exports represents the caller-defined exports from "example:bug/foo".
var Exports struct {
	// Funky represents the caller-defined, exported function "funky".
	//
	//	funky: func(request: request)
	Funky func(request Request)
}

Hoping that the minimal example helps in diagnosing the issue 🙏🏻