Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider module generation improvements #753

Open
saulecabrera opened this issue Sep 12, 2024 · 0 comments
Open

Provider module generation improvements #753

saulecabrera opened this issue Sep 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@saulecabrera
Copy link
Member

What is the idea?

The emit-provider subcommand could benefit from a more defined approach to the provider generation process, particularly regarding the naming of the emitted Wasm binary. We have established a standard nomenclature for defining the instance namespace: javy_quickjs_provider_v<N>.

I propose enhancing the emit-provider tool to:

  • Allow users to specify the location where the binary will be written.
  • Emit a file name that adheres to our standard pattern: javy_quickjs_provider_v.

Additionally, since the provider is currently versioned independently from the CLI and other crates in this repository, I suggest that we properly name the provider in the release artifacts to ensure consistency with our established nomenclature.

What problem does it solve?

The motivation behind this proposal is twofold:

  • To clarify the association between provider versions and their corresponding javy CLI versions and releases.
  • To reduce the likelihood of errors when identifying and instantiating the provider module.
@saulecabrera saulecabrera added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant