-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider setting a lower MSRV #58
Comments
The |
Hmm this would be unfortunate for me personally since the latest version of rust we have at work is 1.34 and I'd like to eventually use saltwater via bindgen on a work project. If this is hard to do for target-lexicon I might add some more hacks to make |
Would it work to change |
Sure, that works for me. Good idea! |
Motivation: I want to use
saltwater
in bindgen (rust-lang/rust-bindgen#1782), but it has an MSRV of 1.34, whichtarget-lexicon
doesn't compile with. It uses the following features not in 1.34:#[nonexhaustive]
: this can be replaced with a#[doc(hidden)] __Nonexhaustive
variant and documentation that the enum is nonexhaustiveSelf::variant
: this can be replaced with the explicit type nameextern crate alloc
in build.rs: this can be replaced byuse std as alloc;
as long as thestd
feature is enabled. I don't need 1.34 support withno_std
.I understand that most bytecodealliance projects aren't considered stable and therefore have no MSRV, but this would help me a lot, I'm willing to make the PRs myself.
The text was updated successfully, but these errors were encountered: