Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcp: make accept and finish-connect async, instead of polling with noop waker #10003

Closed
wants to merge 2 commits into from
Closed

tcp: make accept and finish-connect async, instead of polling with noop waker #10003

wants to merge 2 commits into from

Conversation

pchickey
Copy link
Contributor

@pchickey pchickey commented Jan 13, 2025 •
edited
Loading

Includes #9691
Fixes #9938

Still WIP - letting CI chew on it

Heap-Hop and others added 2 commits January 13, 2025 15:10
@Heap-Hop @pchickey
add test_tcp_input_stream_should_not_wake_on_empty_data
a30d814
@pchickey
wasmtime-wasi: make tcp-socket.finish-connect async
cdaeed0 
this changes the behavior:
* if a connect is not complete when finish-connect is called, it will
  block from wasm guest while the host code awaits completion.
* no longer use a noop waker to poll the connect future, so that tokio
  doesn't miss the changes
@pchickey pchickey marked this pull request as ready for review January 13, 2025 23:16
@pchickey pchickey requested a review from a team as a code owner January 13, 2025 23:16
@pchickey pchickey requested review from fitzgen and removed request for a team January 13, 2025 23:16
@pchickey pchickey changed the title tcp: make finish-connect async, instead of polling with noop waker tcp: make accept and finish-connect async, instead of polling with noop waker Jan 14, 2025
fitzgen
fitzgen approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added the wasi Issues pertaining to WASI label Jan 14, 2025
@pchickey pchickey closed this Jan 14, 2025
@pchickey pchickey deleted the pch/tcp_finish_connect_async branch January 14, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASI socket read returns 0 when it should return at least 1
3 participants
@pchickey @fitzgen @Heap-Hop