User-Agent version is incorrect

[TrevinAvery]

The version number for the default User-Agent header is hardcoded, and is currently out of date. It may be worth auto-updating this value during the build to match the value in the package.json file.

https://github.com/byu-imaal/dohjs/blob/ecf8077e628db214c183ebbedb10f17e83cde045/lib/index.js#L165

[kimbo]

Thank you for reporting this, it's an excellent idea.

[TrevinAvery]

If you want to use webpack, you could solve this issue with the DefinePlugin.

dohjs/webpack.config.js

const webpack = require('webpack')
const package = require('./package.json')

module.exports = {
	plugins: [
		new webpack.DefinePlugin({
			__VERSION__: JSON.stringify(package.version),
		}),
	],
}

dohjs/lib/index.js

'User-Agent': `dohjs/${__VERSION__}`

[kimbo]

@TrevinAvery I haven't mucked about with webpack much, but that seems like a reasonable fix to me.

Also, I believe we could replace our current build process that uses browserify with webpack. That's a separate issue, but if you're interested in tackling that as well, I think we'd welcome that change.